Closed Bug 678330 Opened 10 years ago Closed 10 years ago

Use IOKit to get precise GPU information in GfxInfo on Mac

Categories

(Core :: Graphics, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bjacob, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we use CGL to get GPU information, which is very vague. For example, for NVIDIA cards, it only tells whether the card is a Geforce 8 or newer, or not.

We need to switch to using IOKit like Chrome does: bug 678053 comment 3:

"We use IOKit to scan for PCI-based GPUs.

See http://src.chromium.org/viewvc/chrome/trunk/src/content/gpu/gpu_info_collector_mac.mm?view=markup "

Once this is done, we can stop blacklisting all Geforce 7 and older cards (bug 678053) and only blacklist the cards known to have issues (Geforce 7300 GT).
Blocks: 678053
Attached patch Use IOKit someSplinter Review
Attachment #561598 - Flags: review?(bjacob)
This patch borrows some of the code from Chromium. It doesn't try to detect dual GPU situations and assumes that CGDisplayIOServicePort(kCGDirectMainDisplay) will do the correct thing. This assumption is supported by testing.
Blocks: 687868
Attachment #561598 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/d747526bd066
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Duplicate of this bug: 614073
See Also: → 1386300
You need to log in before you can comment on or make changes to this bug.