Last Comment Bug 678475 - Make mozconfig-find always return an absolute path
: Make mozconfig-find always return an absolute path
fixed-in-bs [qa-]
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: unspecified
: All All
-- normal (vote)
: ---
Assigned To: Siddharth Agarwal [:sid0] (inactive)
: Gregory Szorc [:gps] (away until 2017-03-20)
Depends on: 675691
Blocks: 682897
  Show dependency treegraph
Reported: 2011-08-12 05:13 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2011-09-22 16:47 PDT (History)
6 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1 (1.63 KB, patch)
2011-08-12 05:13 PDT, Siddharth Agarwal [:sid0] (inactive)
ted: review+
asa: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description User image Siddharth Agarwal [:sid0] (inactive) 2011-08-12 05:13:56 PDT
Created attachment 552636 [details] [diff] [review]
patch v1

Relative mozconfigs are currently broken on comm-central because we don't fix the relative-ness for mozilla-central's mozconfig. I think the best approach to fix this is to make mozconfig-find return absolute paths.

The code's adapted from one of the patches in bug 341223, but conflicts with it. It applies on top of the patch in bug 675691.
Comment 1 User image Siddharth Agarwal [:sid0] (inactive) 2011-08-12 05:18:11 PDT
oh yeah, I tested this with
- gmake relative mozconfig
- pymake relative mozconfig
- gmake absolute mozconfig
- pymake absolute mozconfig

and everything worked as expected.
Comment 2 User image Siddharth Agarwal [:sid0] (inactive) 2011-08-14 09:39:23 PDT
Well, turns out using hg diff -U 1 works wonders.
Comment 3 User image Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-15 06:33:57 PDT
Comment 4 User image Mark Banner (:standard8) 2011-08-24 07:15:24 PDT
Comment on attachment 552636 [details] [diff] [review]
patch v1

This is a build-config only regression that we found when generating the first Thunderbird beta for the 7.0 cycle and hit our l10n repacks.

Whilst we could probably somehow upgrade buildbot to sync something, we're not ready to do that yet (blocked by other thing), and this is a clear regression from previous cycles, so I'd really like to get this on mozilla-beta so our builds can progress nicely and we don't have to relbranch for each and every beta of the 7.0 cycle.
Comment 6 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-09-22 16:47:20 PDT
qa- as no QA fix verification needed

Note You need to log in before you can comment on or make changes to this bug.