678475 - Make mozconfig-find always return an absolute path

Status: RESOLVED FIXED

Description

[Siddharth Agarwal [:sid0] (inactive)]

Created attachment 552636 [details] [diff] [review]
patch v1

Relative mozconfigs are currently broken on comm-central because we don't fix the relative-ness for mozilla-central's mozconfig. I think the best approach to fix this is to make mozconfig-find return absolute paths.

The code's adapted from one of the patches in bug 341223, but conflicts with it. It applies on top of the patch in bug 675691.

Comment 1

[Siddharth Agarwal [:sid0] (inactive)]

oh yeah, I tested this with
- gmake relative mozconfig
- pymake relative mozconfig
- gmake absolute mozconfig
- pymake absolute mozconfig

and everything worked as expected.

Comment 2

[Siddharth Agarwal [:sid0] (inactive)]

Well, turns out using hg diff -U 1 works wonders.

https://hg.mozilla.org/projects/build-system/rev/2fed775753c7

Comment 3

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/2fed775753c7

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 552636 [details] [diff] [review]
patch v1

This is a build-config only regression that we found when generating the first Thunderbird beta for the 7.0 cycle and hit our l10n repacks.

Whilst we could probably somehow upgrade buildbot to sync something, we're not ready to do that yet (blocked by other thing), and this is a clear regression from previous cycles, so I'd really like to get this on mozilla-beta so our builds can progress nicely and we don't have to relbranch for each and every beta of the 7.0 cycle.

Comment 5

[christian]

http://hg.mozilla.org/releases/mozilla-beta/rev/12587ddb5436

Comment 6

[Anthony Hughes (:ashughes) [GFX][QA][Mentor]]

qa- as no QA fix verification needed