678509 - Remove showfor JS that filters searches

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[James Socol [:jsocol, :james]]

The showfor search JS sets search forms to look for the current os/fx combination right now. We need to remove that and should just put the correct product tag(s) filter into the search form on each landing page.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

If we filter by product based on OS selected, then we will never be searching for sync and fxhome articles on pages that have showfor selector. Is that ok?

Comment 2

[James Socol [:jsocol, :james]]

We shouldn't change the product based on the OS selected.

On the /home page, we should filter by, e.g. 'desktop' and 'sync' tags, on /mobile, 'mobile' and 'sync', on /fxhome, 'FxHome' and 'sync', etc. The showfor JS doesn't need to change this filter anymore, since showfor is not becoming product-oriented.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

oh yeah, that makes sense!

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to James Socol [:jsocol, :james] from comment #2)
> On the /home page, we should filter by, e.g. 'desktop' and 'sync' tags, on
> /mobile, 'mobile' and 'sync', on /fxhome, 'FxHome' and 'sync', etc.

We already filter articles and questions tagged 'mobile' when searching from /mobile. I will spin off the others as a separate bug that gets fixed once most of the articles have been tagged appropriately. This way we don't get empty search results in the meantime.

Comment 5

[Ricky Rosario [:rrosario, :r1cky]]

Removed the js that adds os and fx params to search from the landing pages:
https://github.com/jsocol/kitsune/commit/57572301247f7f2c52016dc3c3ad57238bafb94f

Filed Bug 680480 for adding filtering based on landing page product.

Comment 7

[Tobias (:Tobbi) Markus]

Verified with Firebug that no hidden input fields are in the DOM after doing a search, especially not those that are type=hidden.