678536 - Letter-HEADS demo, clothing buttons are drawn outside the ovals

Status: RESOLVED INVALID

(Web Compatibility :: Site Reports, defect)

Description

[Torbjörn Andersson]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20100101 Firefox/5.0 Iceweasel/5.0
Build ID: 20110730100538

Steps to reproduce:

I went to the Letter-HEADS demo at https://mozillademos.org/demos/shadows/demo.html


Actual results:

The buttons (parts of the clothing, not GUI buttons) were drawn outside of the ovals.


Expected results:

The buttons should have been drawn inside the ovals, like they used to be. (I could attach screenshots, but they turned out much too large for my liking so I'll only do that if you really need them.)

This appears to be a fairly recent regression. I downloaded some mozilla-central builds from the end of last month, and this is what I found:

Correct: http://hg.mozilla.org/mozilla-central/rev/cef1817c3b13
Buggy: http://hg.mozilla.org/mozilla-central/rev/e9be8677a7ae

I hope that narrows it down enough. The bug is still there in what I believe is the latest Nightly, http://hg.mozilla.org/mozilla-central/rev/f262c389193e

I'm running the unstable version of Debian, so the files I downloaded were called firefox-8.0a1.en-US.linux-i686.tar.bz2. Judging by about:support, my graphics driver is blocked from both WebGL and GPU Accelerated Windows, so I assume it's not a driver issue.

I have not tested this on any other platform.

Please let me know if there is any other information I could provide.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Range of Comment 0: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cef1817c3b13&tochange=e9be8677a7ae

Comment 2

[Torbjörn Andersson]

Out of curiosity, perhaps mixed with a dash of impatience, I got the source code and tried to narrow it down further. Bear in mind that I've never attempted to compile Firefox before, so I may have messed up somewhere. That said...

http://hg.mozilla.org/mozilla-central/rev/eaf738a0e1b3 appears to work correctly.
http://hg.mozilla.org/mozilla-central/rev/74a4b995cfe9 appears to be buggy.

Which, if correct, would make 74a4b995cfe9 the change that caused the regression. It was apparently made to fix bug Bug 505706, which mentions some remaining issues filed as Bug 674449. That one is still open, so perhaps this one is a duplicate? I'll have to admit though that I neither know how the Letter-HEADS demo works, nor what either of these two bug reports mean.

Comment 3

[Boris Zbarsky [:bzbarsky]]

The buttons are in fact absolutely postioned inline-block elements, so the fix for bug 505706 would have affected them.

Furthermore, the block they're inside is "text-align: center", so you're seeing bug 671491.

That said, since that bug is invalid as far as I can tell (in that our rendering is correct), this should be fixed in the demo page, by removing the text-align.

Sadly, the page has no contact info so I have no idea who would be able to fix it.  :(

Comment 4

[Boris Zbarsky [:bzbarsky]]

Well, or the buttons could be made into blocks, not inline-blocks.

Torbjörn, thank you for figuring out the regression range here.  It made it really simple to figure out what's going on!

Comment 5

[Torbjörn Andersson]

The demo page itself doesn't have any visible contact address as far as I can tell. However, the Web o' Wonder page - https://demos.mozilla.org/en-US/#shadows - does say it's "by Simurai" and has a link to what looks like it could be the author's web page. Funny, I didn't even notice that until today.

While I'm commenting, I can confirm that the demo renders the way its author seems to have intended in both Opera 11 and Chrome 13. This is consistent with the comments for bug 671491, which I guess is a good ting in this case. (If anyone wonders, Internet Explorer 9 renders it differently than any other browser I tried, putting all five buttons in the same position to the up and left of the oval.)

I'm glad the regression testing helped. It took much longer than I had anticipated to build and rebuild Firefox on my computer, so it's good to know that the time wasn't wasted.

Comment 6

[Karl Dubost💡 :karlcow]

Going to https://mozillademos.org/demos/shadows/demo.html
Shows a Untrusted communication warning.

And https://demos.mozilla.org/ is not available anymore.

I will close that as INVALID.

Comment 7

[Torbjörn Andersson]

I can still find the demo, with the same glitch, at https://developer.mozilla.org/en-US/demos/detail/the-letter-heads though.

Comment 8

[Karl Dubost💡 :karlcow]

Yes my bad. And I have opened a bug this morning about the SSL stuff.
Thanks for the link.

Comment 9

[Karl Dubost💡 :karlcow]

So removing the 

#mr, #ms {
    text-align: center;
}

doesn't fix the issue. It puts the button in a better position but not the right position.
The suggestion in Comment #3 doesn't fix it.

Comment 10

[Karl Dubost💡 :karlcow]

We are now redirected to 
https://developer.mozilla.org/en-US/docs/Web/Demos_of_open_web_technologies

And the demo doesn't exist anymore?
Let's close it as INVALID. until someone finds yet another version ;)

Comment 11

[Torbjörn Andersson]

I don't know if it's still reliably available online anywhere, so it might not matter, but you can still find the source code for it at https://github.com/mozilla/webowonder-demos