The default bug view has changed. See this FAQ.

Drop singleDeviceInterval to 1 hour

RESOLVED WONTFIX

Status

Cloud Services
Firefox Sync: Backend
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

unspecified
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox7 wontfix, firefox8 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

In bug 664792 we got rid of heartbeat-triggered syncs because regular syncs are nearly as efficient as doing heartbeats. However, we forgot to drop the singleDeviceInterval to the heartbeat frequency which was 1 hour.
Created attachment 552740 [details] [diff] [review]
v1
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #552740 - Flags: review?(mconnor)
Created attachment 552754 [details] [diff] [review]
v1

lolnub
Attachment #552740 - Attachment is obsolete: true
Attachment #552740 - Flags: review?(mconnor)
Attachment #552754 - Flags: review?(mconnor)
Comment on attachment 552754 [details] [diff] [review]
v1

At which point... why not just use idleInterval?  But... minimal is good for Fx7
Attachment #552754 - Flags: review?(mconnor) → review+
(In reply to Mike Connor [:mconnor] from comment #3)
> At which point... why not just use idleInterval?  But... minimal is good for
> Fx7

Yep. Also, still useful to keep them separate for QA because it allows us to test different code paths.
Comment on attachment 552754 [details] [diff] [review]
v1

Requesting approval for Aurora. The last follow-up for bug 664792 (I swear!). Risk is minimal, it just changes a pref value that we forgot to adjust.
Attachment #552754 - Flags: approval-mozilla-aurora?
http://hg.mozilla.org/integration/mozilla-inbound/rev/a68442b5ff5c
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a68442b5ff5c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8

Updated

6 years ago
Attachment #552754 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/654659c31938
Target Milestone: mozilla8 → mozilla7

Updated

6 years ago
Depends on: 598774

Comment 9

6 years ago
I backed this out of mozilla-beta due to bug 598774:

http://hg.mozilla.org/releases/mozilla-beta/rev/e5566280b79d

I left in in aurora8 and mozilla-central for now. If you disagree, please email me directly or release-drivers@mozilla.org.
status-firefox7: --- → wontfix
Anything QA should be looking for with this backout, str, etc?
I disagree with this backout, will follow up as advised in comment 9.

Comment 12

6 years ago
I backed this out of beta8 as well.
status-firefox8: --- → wontfix

Comment 13

6 years ago
Actually, because of the investigation in bug 598774 we are going to re-land this on beta8.

Updated

6 years ago
status-firefox8: wontfix → fixed
(Assignee)

Updated

6 years ago
Depends on: 693758
Reopening this as we've decided to back this out altogether (see bug 694149). Will be WONTFIXing once bug 694149 lands.
Status: RESOLVED → REOPENED
Depends on: 694149
No longer depends on: 598774, 693758
Resolution: FIXED → ---
WONTFIXing this as planned (comment 14)
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.