Remove --disable-necko-disk-cache

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: Matheus Kerschbaum)

Tracking

({dev-doc-complete})

Trunk
mozilla9
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 552941 [details] [diff] [review]
patch
Attachment #552941 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Blocks: 678794
The patch looks fine if we want to do this ... I'm just not sure if we want to do this.
Disk cache has a pref, right? (We pref it off in Fennec, IIRC.) Unless building it requires some prerequisites beyond building base Gecko, we should probably just unconditionally build it.
I believe so.  Just want confirmation from some Necko folks before we do this.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

6 years ago
Assignee: nobody → matjk7
Comment on attachment 552941 [details] [diff] [review]
patch

Review of attachment 552941 [details] [diff] [review]:
-----------------------------------------------------------------

Michal's good with this, so let's do it.
Attachment #552941 - Flags: review?(khuey) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/5046e7177feb
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/5046e7177feb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
Not much to doc here--I don't see any refs to using this flag on the web. If true, I wouldn't go out of my way to doc that it's been removed.  I doubt anyone's been using it.
(Assignee)

Comment 9

6 years ago
(In reply to Jason Duell (:jduell) from comment #8)
> Not much to doc here--I don't see any refs to using this flag on the web. If
> true, I wouldn't go out of my way to doc that it's been removed.  I doubt
> anyone's been using it.

It's mentioned in https://developer.mozilla.org/en/Configuring_Build_Options but that's about it.
That doc is updated, and the change mentioned in passing on Firefox 8 for developers.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.