Last Comment Bug 678792 - Remove --disable-necko-disk-cache
: Remove --disable-necko-disk-cache
Status: RESOLVED FIXED
[inbound]
: dev-doc-complete
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Matheus Kerschbaum
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks: 678794
  Show dependency treegraph
 
Reported: 2011-08-14 00:08 PDT by Matheus Kerschbaum
Modified: 2011-08-23 12:09 PDT (History)
10 users (show)
matjk7: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (18.48 KB, patch)
2011-08-14 00:10 PDT, Matheus Kerschbaum
jduell.mcbugs: review+
Details | Diff | Splinter Review

Description Matheus Kerschbaum 2011-08-14 00:08:30 PDT

    
Comment 1 Matheus Kerschbaum 2011-08-14 00:10:25 PDT
Created attachment 552941 [details] [diff] [review]
patch
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-15 05:41:51 PDT
The patch looks fine if we want to do this ... I'm just not sure if we want to do this.
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-08-15 05:52:34 PDT
Disk cache has a pref, right? (We pref it off in Fennec, IIRC.) Unless building it requires some prerequisites beyond building base Gecko, we should probably just unconditionally build it.
Comment 4 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-08-15 06:28:25 PDT
I believe so.  Just want confirmation from some Necko folks before we do this.
Comment 5 Jason Duell [:jduell] (needinfo me) 2011-08-17 15:14:07 PDT
Comment on attachment 552941 [details] [diff] [review]
patch

Review of attachment 552941 [details] [diff] [review]:
-----------------------------------------------------------------

Michal's good with this, so let's do it.
Comment 7 Marco Bonardo [::mak] 2011-08-19 03:05:32 PDT
http://hg.mozilla.org/mozilla-central/rev/5046e7177feb
Comment 8 Jason Duell [:jduell] (needinfo me) 2011-08-19 16:38:46 PDT
Not much to doc here--I don't see any refs to using this flag on the web. If true, I wouldn't go out of my way to doc that it's been removed.  I doubt anyone's been using it.
Comment 9 Matheus Kerschbaum 2011-08-19 16:43:32 PDT
(In reply to Jason Duell (:jduell) from comment #8)
> Not much to doc here--I don't see any refs to using this flag on the web. If
> true, I wouldn't go out of my way to doc that it's been removed.  I doubt
> anyone's been using it.

It's mentioned in https://developer.mozilla.org/en/Configuring_Build_Options but that's about it.
Comment 10 Eric Shepherd [:sheppy] 2011-08-23 12:09:04 PDT
That doc is updated, and the change mentioned in passing on Firefox 8 for developers.

Note You need to log in before you can comment on or make changes to this bug.