Closed Bug 678792 Opened 10 years ago Closed 10 years ago

Remove --disable-necko-disk-cache

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: matjk7, Assigned: matjk7)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [inbound])

Attachments

(1 file)

No description provided.
Flags: in-testsuite-
Attached patch patchSplinter Review
Attachment #552941 - Flags: review?(khuey)
Blocks: 678794
The patch looks fine if we want to do this ... I'm just not sure if we want to do this.
Disk cache has a pref, right? (We pref it off in Fennec, IIRC.) Unless building it requires some prerequisites beyond building base Gecko, we should probably just unconditionally build it.
I believe so.  Just want confirmation from some Necko folks before we do this.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → matjk7
Comment on attachment 552941 [details] [diff] [review]
patch

Review of attachment 552941 [details] [diff] [review]:
-----------------------------------------------------------------

Michal's good with this, so let's do it.
Attachment #552941 - Flags: review?(khuey) → review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/5046e7177feb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Keywords: dev-doc-needed
Not much to doc here--I don't see any refs to using this flag on the web. If true, I wouldn't go out of my way to doc that it's been removed.  I doubt anyone's been using it.
(In reply to Jason Duell (:jduell) from comment #8)
> Not much to doc here--I don't see any refs to using this flag on the web. If
> true, I wouldn't go out of my way to doc that it's been removed.  I doubt
> anyone's been using it.

It's mentioned in https://developer.mozilla.org/en/Configuring_Build_Options but that's about it.
That doc is updated, and the change mentioned in passing on Firefox 8 for developers.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.