678792 - Remove --disable-necko-disk-cache

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Matheus Kerschbaum]

Attachment: patch

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The patch looks fine if we want to do this ... I'm just not sure if we want to do this.

Comment 3

[(not currently active) Ted Mielczarek]

Disk cache has a pref, right? (We pref it off in Fennec, IIRC.) Unless building it requires some prerequisites beyond building base Gecko, we should probably just unconditionally build it.

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I believe so.  Just want confirmation from some Necko folks before we do this.

Comment 5

[Jason Duell]

Comment on attachment 552941 [details] [diff] [review]
patch

Review of attachment 552941 [details] [diff] [review]:
-----------------------------------------------------------------

Michal's good with this, so let's do it.

Comment 6

[Marco Bonardo [:mak]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5046e7177feb

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/5046e7177feb

Comment 8

[Jason Duell]

Not much to doc here--I don't see any refs to using this flag on the web. If true, I wouldn't go out of my way to doc that it's been removed.  I doubt anyone's been using it.

Comment 9

[Matheus Kerschbaum]

(In reply to Jason Duell (:jduell) from comment #8)
> Not much to doc here--I don't see any refs to using this flag on the web. If
> true, I wouldn't go out of my way to doc that it's been removed.  I doubt
> anyone's been using it.

It's mentioned in https://developer.mozilla.org/en/Configuring_Build_Options but that's about it.

Comment 10

[Eric Shepherd [:sheppy]]

That doc is updated, and the change mentioned in passing on Firefox 8 for developers.