Closed Bug 678794 Opened 10 years ago Closed 10 years ago

Remove NECKO_OFFLINE_CACHE checks

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: matjk7, Assigned: matjk7)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

No description provided.
Flags: in-testsuite-
Depends on: 675500, 678792
Attached patch patchSplinter Review
Attachment #552942 - Flags: review?(jduell.mcbugs)
Michal,

This seems fine to me.  Can you think of any reason we'd want to keep the offline cache code optional at compilation time?  If not I'll +r this.
I don't see any reason to keep it. Maybe Honza?

Btw. we have the same compile time option for the disk cache which could be IMO removed too.
(In reply to Michal Novotny (:michal) from comment #3)
> Btw. we have the same compile time option for the disk cache which could be
> IMO removed too.

That is bug 678792.
Assignee: nobody → matjk7
Comment on attachment 552942 [details] [diff] [review]
patch

If Michal's good with this, then let's do it.
Attachment #552942 - Flags: review?(jduell.mcbugs) → review+
Keywords: checkin-needed
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
http://hg.mozilla.org/mozilla-central/rev/8fbc35ff4d7c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.