Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 678794 - Remove NECKO_OFFLINE_CACHE checks
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Matheus Kerschbaum
: Gregory Szorc [:gps]
Depends on: 675500 678792
  Show dependency treegraph
Reported: 2011-08-14 00:30 PDT by Matheus Kerschbaum
Modified: 2011-08-19 03:05 PDT (History)
7 users (show)
matjk7: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (19.03 KB, patch)
2011-08-14 00:32 PDT, Matheus Kerschbaum
jduell.mcbugs: review+
Details | Diff | Splinter Review

Description Matheus Kerschbaum 2011-08-14 00:30:11 PDT

Comment 1 Matheus Kerschbaum 2011-08-14 00:32:12 PDT
Created attachment 552942 [details] [diff] [review]
Comment 2 Jason Duell [:jduell] (needinfo me) 2011-08-15 22:24:36 PDT

This seems fine to me.  Can you think of any reason we'd want to keep the offline cache code optional at compilation time?  If not I'll +r this.
Comment 3 Michal Novotny (:michal) 2011-08-16 15:10:20 PDT
I don't see any reason to keep it. Maybe Honza?

Btw. we have the same compile time option for the disk cache which could be IMO removed too.
Comment 4 Matheus Kerschbaum 2011-08-16 15:24:14 PDT
(In reply to Michal Novotny (:michal) from comment #3)
> Btw. we have the same compile time option for the disk cache which could be
> IMO removed too.

That is bug 678792.
Comment 5 Jason Duell [:jduell] (needinfo me) 2011-08-17 15:12:11 PDT
Comment on attachment 552942 [details] [diff] [review]

If Michal's good with this, then let's do it.
Comment 7 Marco Bonardo [::mak] 2011-08-19 03:05:47 PDT

Note You need to log in before you can comment on or make changes to this bug.