67884 - Show Add Bookmark dialog pref is reversed between dialog & pref panel

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

The Add Bookmark dialog has a '[ ] Don't show this again' box that sets a pref
to make sure this dialog doesn't appear again, and the corresponding entry in
Preferences reads [ ] Always ask me before adding a new bookmark... These text
strings are fine, but the logic on one end needs to be reversed to ensure that
the pref value gets set as the user expects. I think that this should be the
dialog end, as it's easier to do so there as the prefwindow code is fairly
automated.

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

nsbeta1, .9

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

*** Bug 67824 has been marked as a duplicate of this bug. ***

Comment 3

[sairuh (rarely reading bugmail)]

*** Bug 70118 has been marked as a duplicate of this bug. ***

Comment 4

[Boris Zbarsky [:bzbarsky]]

As I commented in bug 70118, the code for the bookmarks manager matches the name
of the pref.  So either the pref needs to be renamed, or the wording in
preferences needs to be changed from "Always Ask me to choose a title
and folder when adding a new Bookmark" to "Do not ask me to choose ..." or
"Automatically choose ..."

Just flipping the boolean test in the bookmark manger will make things very
confusing for someone reading the code in the future (ie, when the pref
browser.bookmarks.add_without_dialog is true we would be popping up the dialog).

Comment 5

[timeless]

Attachment: flop Disable to Enable

Comment 6

[Mark Olson]

looks good to me.  r=mao

Comment 7

[Alec Flett]

sr=alecf

Comment 8

[Paul Chen]

Wait, wait, wait. The way the preference works, the checkbox in the pref panel
needs to change, not the checkbox in the dialog! Also, the file dialog does not
come up at all on my mac. Sigh. Anyway, I'll try to get a patch done very soon.

Comment 9

[Paul Chen]

Wait, never mind, timeless did the right thing. I'm an idiot, or just too
skittish at the moment.

Comment 10

[timeless]

fix checked in

Comment 11

[Claudius Gayle]

VERIFIED Fixed with 2001032904 builds