Closed Bug 678979 Opened 8 years ago Closed 8 years ago

Remove README.txt from release packages

Categories

(SeaMonkey :: Build Config, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.7

People

(Reporter: Callek, Assigned: ewong)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #678963 +++

+++ This bug was initially created as a clone of Bug #561481 +++

Bug 561481 pointed out that the readme file was out of date, and that it isn't very useful anyway. Nor does there seem much point in keeping it up to date.

Therefore I think we can remove it as well.

------

I also agree this is useful for SeaMonkey
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Comment on attachment 558038 [details] [diff] [review]
Removed README.Txt from release packages. (v1)

I know you were holding off on requesting review until you tested, but figured I would give you guidance early (especially since locales/* won't be tested in your default code paths in a normal build, and iirc you don't have a mac to test with, which is where these issues were anyway)

> MOZ_PKG_MAC_ICON=branding/disk.icns
>-MOZ_PKG_MAC_EXTRA=--symlink "/Applications:/ " \
>-                  --copy "$(call EXPAND_LOCALE_SRCDIR,suite/locales)/installer/mac/README.txt"

This alone is wrong, just kill the line continuation and the --copy line (we need --symlink) [Same in suite/locales/Makefile.in]

>--- a/suite/locales/Makefile.in
>+++ b/suite/locales/Makefile.in
>@@ -112,40 +110,25 @@ include $(topsrcdir)/config/rules.mk
>-ifneq (,$(filter cocoa,$(MOZ_WIDGET_TOOLKIT)))
>-README_FILES = \
>-	installer/mac/README.txt \
>-	$(NULL)
>-else
>-ifeq ($(OS_ARCH),WINNT)
>-README_FILES = \
>-	installer/windows/README.txt \
>-	$(NULL)
>-else
>-README_FILES = \
>-	installer/unix/README \
>-	$(NULL)
>-endif
> endif

remove that last endif


> PROFILE_FILES = \
> 	localstore.rdf \
> 	mimeTypes.rdf \
> 	$(NULL)
> 
> PROFILE_CHROME = userChrome-example.css userContent-example.css
> 
>-libs:: $(addprefix $(LOCALE_SRCDIR)/,$(README_FILES))
> ifeq ($(OS_ARCH),WINNT)
> 	$(EXIT_ON_ERROR) \
> 	for file in $^; do \
> 	  $(PERL) -pe 's/(?<!\r)\n/\r\n/g;' < $$file > $(FINAL_TARGET)/`basename $$file`; \
> 	done
> else
> ifneq ($(OS_ARCH),OS2)
> 	$(SYSINSTALL) $(IFLAGS1) $^ $(FINAL_TARGET)

These lines under that libs:: line you are dropping needs to be removed. these are what was "installing" the README, and I would be shocked if you didn't get Make syntax errors trying to run this makefile if you don't.

Also need to kill off installer/unix/README as well (and those directories [mac/unix, win needs to stay for other files] ;-) )
Attachment #558038 - Flags: review-
Attachment #558038 - Attachment is obsolete: true
Attachment #558207 - Flags: review?(bugspam.Callek)
Comment on attachment 558207 [details] [diff] [review]
Remove README.txt from release packages (v2) [Checkin: comment 5]

Looks Good, thanks.
Attachment #558207 - Flags: review?(bugspam.Callek) → review+
Keywords: checkin-needed
Comment on attachment 558207 [details] [diff] [review]
Remove README.txt from release packages (v2) [Checkin: comment 5]

http://hg.mozilla.org/comm-central/rev/6123910b473d
Attachment #558207 - Attachment description: Remove README.txt from release packages (v2) → Remove README.txt from release packages (v2) [Checkin: comment 5]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
The layout of the mac installer window will now probably need some adjustment as the readme was removed...
You need to log in before you can comment on or make changes to this bug.