Closed
Bug 679218
Opened 13 years ago
Closed 13 years ago
Update branding for Thunderbird's nightly equivalent channel: Daily
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: andreasn, Assigned: standard8)
Details
Attachments
(2 files, 1 obsolete file)
724.08 KB,
patch
|
standard8
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
2.16 KB,
patch
|
bwinton
:
review+
bwinton
:
ui-review+
|
Details | Diff | Splinter Review |
Same as bug #664794 but for Daily.
Reporter | ||
Comment 1•13 years ago
|
||
Attachment #553308 -
Flags: ui-review?(bwinton)
Attachment #553308 -
Flags: review?(mbanner)
Comment 2•13 years ago
|
||
Comment on attachment 553308 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all
"mail/branding/nightly/os2/messengerWindow.ico" OS/2?!? :)
I suspect we want to change "Shredder" to "Daily" as part of this patch, too. Or at least as part of this bug.
I tested the patch on Mac and Linux, and they look good, so I'm going to say ui-r=me, under the assumption that you've tested it on Windows, and under the assumption that we're going to change the text in a different patch.
Thanks,
Blake.
Attachment #553308 -
Flags: ui-review?(bwinton) → ui-review+
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 553308 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all
Can you do about-wordmark.png as well please, and I'll attach a patch that does the actual renaming.
Attachment #553308 -
Flags: review?(mbanner) → review-
Reporter | ||
Comment 4•13 years ago
|
||
Here is the patch with the daily word mark as well.
Attachment #553308 -
Attachment is obsolete: true
Attachment #558446 -
Flags: ui-review+
Attachment #558446 -
Flags: review?(mbanner)
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 558446 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all v2
Looks good, I'll land this when I land the patch I'm just about to post.
Attachment #558446 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 6•13 years ago
|
||
This renames the builds from Daily to Shredder, does everything that's necessary.
Mac & Linux try server builds here: https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/bugzilla@standard8.plus.com-c92b28cd640c/
iirc the windows one had builder issues.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #558869 -
Flags: ui-review?(bwinton)
Attachment #558869 -
Flags: review?(bwinton)
Comment 7•13 years ago
|
||
Comment on attachment 558869 [details] [diff] [review]
Text renames
Review of attachment 558869 [details] [diff] [review]:
-----------------------------------------------------------------
So pretty… :) ui-r=me.
The What's New page, and http://dl.dropbox.com/u/2301433/Screenshots/DailyShredder.png both say "Shredder". (I expect the first one is a web fix, but the second probably lives in "mail/branding/nightly/content/about-wordmark.png", and so should be covered by this patch, imo.
I also get the following hits when I search for "Shredder":
mail/branding/aurora/locales/jar.mn
5:# Shredder branding only exists in en-US
mail/installer/windows/nsis/shared.nsh
546: ; Remove the Shredder clients key if its default icon contains thunderbird.exe
548: ReadRegStr $1 HKLM "SOFTWARE\clients\mail\Shredder\DefaultIcon" ""
551: DeleteRegKey HKLM "SOFTWARE\clients\mail\Shredder"
555: ReadRegStr $1 HKLM "SOFTWARE\clients\news\Shredder\DefaultIcon" ""
558: DeleteRegKey HKLM "SOFTWARE\clients\news\Shredder"
mail/locales/en-US/chrome/messenger/preferences/preferences.properties
39:# %2$S = brandShortName from brand.properties (for example "Shredder")
mail/test/resources/mozrunner/mozrunner/__init__.py
362: names = ["thunderbird", "shredder"]
559: names = ["thunderbird", "shredder"]
mailnews/test/data/external-attach-test
7:User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre) Gecko/20090817 Shredder/3.0b4pre
mailnews/test/data/image-attach-test
7:User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre) Gecko/20090817 Shredder/3.0b4pre
mailnews/test/performance/bloat/runtest.py
72: defaults["brand"] = "Shredder"
mozilla/extensions/spellcheck/locales/en-US/hunspell/dictionary-sources/hunspell-en_US-20081205.dic
43015:shredder/MS
mozilla/extensions/spellcheck/locales/en-US/hunspell/en-US.dic
49165:shredder/MS
mozilla/testing/firebug/mozrunner/mozrunner/runner.py
241: names = ["thunderbird", "shredder"]
mozilla/testing/mozmill/mozrunner/mozrunner/__init__.py
325: names = ["thunderbird", "shredder"]
508: names = ["thunderbird", "shredder"]
But r=me with those fixed, or explained. (That nsis one in particular looks like it might be a bit of a pain to handle correctly.)
Thanks,
Blake.
Attachment #558869 -
Flags: ui-review?(bwinton)
Attachment #558869 -
Flags: ui-review+
Attachment #558869 -
Flags: review?(bwinton)
Attachment #558869 -
Flags: review+
Assignee | ||
Comment 8•13 years ago
|
||
> The What's New page, and
> http://dl.dropbox.com/u/2301433/Screenshots/DailyShredder.png both say
> "Shredder". (I expect the first one is a web fix, but the second probably
> lives in "mail/branding/nightly/content/about-wordmark.png", and so should
> be covered by this patch, imo.
Fixing this in separate web bugs.
> mail/branding/aurora/locales/jar.mn
> 5:# Shredder branding only exists in en-US
Not fussed about that ;-)
> mail/installer/windows/nsis/shared.nsh
> 546: ; Remove the Shredder clients key if its default icon contains
> thunderbird.exe
> 548: ReadRegStr $1 HKLM "SOFTWARE\clients\mail\Shredder\DefaultIcon" ""
> 551: DeleteRegKey HKLM "SOFTWARE\clients\mail\Shredder"
> 555: ReadRegStr $1 HKLM "SOFTWARE\clients\news\Shredder\DefaultIcon" ""
> 558: DeleteRegKey HKLM "SOFTWARE\clients\news\Shredder"
Not sure what this is doing, I think it is old cleanup. We shouldn't need to do it now I believe.
> mail/locales/en-US/chrome/messenger/preferences/preferences.properties
> 39:# %2$S = brandShortName from brand.properties (for example "Shredder")
Not worried, just an example.
> mail/test/resources/mozrunner/mozrunner/__init__.py
> 362: names = ["thunderbird", "shredder"]
> 559: names = ["thunderbird", "shredder"]
This is mozmill code and it is their detection routine. Doesn't affect us, though I'll let them know about the change.
> mailnews/test/data/external-attach-test
> mailnews/test/data/image-attach-test
Not going to touch test code, that's just examples.
> mailnews/test/performance/bloat/runtest.py
> 72: defaults["brand"] = "Shredder"
I'll change this one on checkin, although its just a default value.
> mozilla/extensions/spellcheck/locales/en-US/hunspell/dictionary-sources/
> hunspell-en_US-20081205.dic
> mozilla/extensions/spellcheck/locales/en-US/hunspell/en-US.dic
Not going to touch dictionaries ;-)
> mozilla/testing/firebug/mozrunner/mozrunner/runner.py
> mozilla/testing/mozmill/mozrunner/mozrunner/__init__.py
MozMill stuff again.
> But r=me with those fixed, or explained. (That nsis one in particular looks
> like it might be a bit of a pain to handle correctly.)
I don't see an nsis one here...
Assignee | ||
Comment 9•13 years ago
|
||
This landed a while ago.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•