679218 - Update branding for Thunderbird's nightly equivalent channel: Daily

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Andreas Nilsson (:andreasn)]

Same as bug #664794 but for Daily.

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: Daily icons for windows, linux, osx, dialogs et all

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 553308 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all

"mail/branding/nightly/os2/messengerWindow.ico"  OS/2?!?  :)

I suspect we want to change "Shredder" to "Daily" as part of this patch, too.  Or at least as part of this bug.

I tested the patch on Mac and Linux, and they look good, so I'm going to say ui-r=me, under the assumption that you've tested it on Windows, and under the assumption that we're going to change the text in a different patch.

Thanks,
Blake.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 553308 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all

Can you do about-wordmark.png as well please, and I'll attach a patch that does the actual renaming.

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: Daily icons for windows, linux, osx, dialogs et all v2

Here is the patch with the daily word mark as well.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 558446 [details] [diff] [review]
Daily icons for windows, linux, osx, dialogs et all v2

Looks good, I'll land this when I land the patch I'm just about to post.

Comment 6

[Mark Banner (:standard8)]

Attachment: Text renames

This renames the builds from Daily to Shredder, does everything that's necessary.

Mac & Linux try server builds here: https://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-c92b28cd640c/

iirc the windows one had builder issues.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 558869 [details] [diff] [review]
Text renames

Review of attachment 558869 [details] [diff] [review]:
-----------------------------------------------------------------

So pretty…  :)  ui-r=me.


The What's New page, and http://dl.dropbox.com/u/2301433/Screenshots/DailyShredder.png both say "Shredder".  (I expect the first one is a web fix, but the second probably lives in "mail/branding/nightly/content/about-wordmark.png", and so should be covered by this patch, imo.


I also get the following hits when I search for "Shredder":

mail/branding/aurora/locales/jar.mn
5:# Shredder branding only exists in en-US

mail/installer/windows/nsis/shared.nsh
546:  ; Remove the Shredder clients key if its default icon contains thunderbird.exe
548:  ReadRegStr $1 HKLM "SOFTWARE\clients\mail\Shredder\DefaultIcon" ""
551:    DeleteRegKey HKLM "SOFTWARE\clients\mail\Shredder"
555:  ReadRegStr $1 HKLM "SOFTWARE\clients\news\Shredder\DefaultIcon" ""
558:    DeleteRegKey HKLM "SOFTWARE\clients\news\Shredder"

mail/locales/en-US/chrome/messenger/preferences/preferences.properties
39:# %2$S = brandShortName from brand.properties (for example "Shredder")

mail/test/resources/mozrunner/mozrunner/__init__.py
362:    names = ["thunderbird", "shredder"]
559:    names = ["thunderbird", "shredder"]

mailnews/test/data/external-attach-test
7:User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre) Gecko/20090817 Shredder/3.0b4pre

mailnews/test/data/image-attach-test
7:User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.3pre) Gecko/20090817 Shredder/3.0b4pre

mailnews/test/performance/bloat/runtest.py
72:        defaults["brand"] = "Shredder"

mozilla/extensions/spellcheck/locales/en-US/hunspell/dictionary-sources/hunspell-en_US-20081205.dic
43015:shredder/MS

mozilla/extensions/spellcheck/locales/en-US/hunspell/en-US.dic
49165:shredder/MS

mozilla/testing/firebug/mozrunner/mozrunner/runner.py
241:    names = ["thunderbird", "shredder"]

mozilla/testing/mozmill/mozrunner/mozrunner/__init__.py
325:    names = ["thunderbird", "shredder"]
508:    names = ["thunderbird", "shredder"]

But r=me with those fixed, or explained.  (That nsis one in particular looks like it might be a bit of a pain to handle correctly.)

Thanks,
Blake.

Comment 8

[Mark Banner (:standard8)]

> The What's New page, and
> http://dl.dropbox.com/u/2301433/Screenshots/DailyShredder.png both say
> "Shredder".  (I expect the first one is a web fix, but the second probably
> lives in "mail/branding/nightly/content/about-wordmark.png", and so should
> be covered by this patch, imo.

Fixing this in separate web bugs.

> mail/branding/aurora/locales/jar.mn
> 5:# Shredder branding only exists in en-US

Not fussed about that ;-)

> mail/installer/windows/nsis/shared.nsh
> 546:  ; Remove the Shredder clients key if its default icon contains
> thunderbird.exe
> 548:  ReadRegStr $1 HKLM "SOFTWARE\clients\mail\Shredder\DefaultIcon" ""
> 551:    DeleteRegKey HKLM "SOFTWARE\clients\mail\Shredder"
> 555:  ReadRegStr $1 HKLM "SOFTWARE\clients\news\Shredder\DefaultIcon" ""
> 558:    DeleteRegKey HKLM "SOFTWARE\clients\news\Shredder"

Not sure what this is doing, I think it is old cleanup. We shouldn't need to do it now I believe.

> mail/locales/en-US/chrome/messenger/preferences/preferences.properties
> 39:# %2$S = brandShortName from brand.properties (for example "Shredder")

Not worried, just an example.

> mail/test/resources/mozrunner/mozrunner/__init__.py
> 362:    names = ["thunderbird", "shredder"]
> 559:    names = ["thunderbird", "shredder"]

This is mozmill code and it is their detection routine. Doesn't affect us, though I'll let them know about the change.

> mailnews/test/data/external-attach-test
> mailnews/test/data/image-attach-test

Not going to touch test code, that's just examples.

> mailnews/test/performance/bloat/runtest.py
> 72:        defaults["brand"] = "Shredder"

I'll change this one on checkin, although its just a default value.

> mozilla/extensions/spellcheck/locales/en-US/hunspell/dictionary-sources/
> hunspell-en_US-20081205.dic
> mozilla/extensions/spellcheck/locales/en-US/hunspell/en-US.dic

Not going to touch dictionaries ;-)

> mozilla/testing/firebug/mozrunner/mozrunner/runner.py
> mozilla/testing/mozmill/mozrunner/mozrunner/__init__.py

MozMill stuff again.

> But r=me with those fixed, or explained.  (That nsis one in particular looks
> like it might be a bit of a pain to handle correctly.)

I don't see an nsis one here...

Comment 9

[Mark Banner (:standard8)]

This landed a while ago.