Last Comment Bug 679332 - Kill GET_BOOLBIT/SET_BOOLBIT
: Kill GET_BOOLBIT/SET_BOOLBIT
Status: RESOLVED FIXED
[qa-]
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 698275
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-16 06:17 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-11-16 10:25 PST (History)
3 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (28.16 KB, patch)
2011-10-30 15:55 PDT, :Ms2ger (⌚ UTC+1/+2)
mounir: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-08-16 06:17:20 PDT

    
Comment 1 Mounir Lamouri (:mounir) 2011-08-16 06:23:27 PDT
Please! :)
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-10-30 15:55:37 PDT
Created attachment 570581 [details] [diff] [review]
Patch v1

Did I hear "Please!"? :)
Comment 3 Mounir Lamouri (:mounir) 2011-10-31 04:54:36 PDT
Comment on attachment 570581 [details] [diff] [review]
Patch v1

Review of attachment 570581 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +700,5 @@
>        }
>        break;
>      case NS_FORM_INPUT_RADIO:
>      case NS_FORM_INPUT_CHECKBOX:
> +      if (mCheckedChanged) {

You should whether use GetCheckedChanged() or open a follow up to remove this method (and all similar ones).
I would prefer the later ;)

@@ +783,5 @@
>  
>      //
>      // Checked must be set no matter what type of control it is, since
>      // GetChecked() must reflect the new value
> +    if (aName == nsGkAtoms::checked && !mCheckedChanged) {

ditto

@@ +1427,5 @@
>  nsHTMLInputElement::DoSetCheckedChanged(bool aCheckedChanged,
>                                          bool aNotify)
>  {
>    if (mType == NS_FORM_INPUT_RADIO) {
> +    if (mCheckedChanged != aCheckedChanged) {

ditto

@@ +3163,5 @@
>    
>    nsEventStates state = nsGenericHTMLFormElement::IntrinsicState();
>    if (mType == NS_FORM_INPUT_CHECKBOX || mType == NS_FORM_INPUT_RADIO) {
>      // Check current checked state (:checked)
> +    if (mChecked) {

ditto (with GetChecked() instead of GetCheckedChanged())

@@ +3320,5 @@
>    //
>    // For integrity purposes, we have to ensure that "checkedChanged" is
>    // the same for this new element as for all the others in the group
>    //
> +  bool checkedChanged = mCheckedChanged;

ditto

::: content/html/content/src/nsHTMLInputElement.h
@@ +597,5 @@
> +  /**
> +   * The type of this input (<input type=...>) as an integer.
> +   * @see nsIFormControl.h (specifically NS_FORM_INPUT_*)
> +   */
> +  PRUint8                  mType;

Would it make sense to add " : 8" here?
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2011-11-16 10:25:50 PST
https://hg.mozilla.org/mozilla-central/rev/4edb27f15750

Note You need to log in before you can comment on or make changes to this bug.