679332 - Kill GET_BOOLBIT/SET_BOOLBIT

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Mounir Lamouri (:mounir)]

Please! :)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Did I hear "Please!"? :)

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 570581 [details] [diff] [review]
Patch v1

Review of attachment 570581 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: content/html/content/src/nsHTMLInputElement.cpp
@@ +700,5 @@
>        }
>        break;
>      case NS_FORM_INPUT_RADIO:
>      case NS_FORM_INPUT_CHECKBOX:
> +      if (mCheckedChanged) {

You should whether use GetCheckedChanged() or open a follow up to remove this method (and all similar ones).
I would prefer the later ;)

@@ +783,5 @@
>  
>      //
>      // Checked must be set no matter what type of control it is, since
>      // GetChecked() must reflect the new value
> +    if (aName == nsGkAtoms::checked && !mCheckedChanged) {

ditto

@@ +1427,5 @@
>  nsHTMLInputElement::DoSetCheckedChanged(bool aCheckedChanged,
>                                          bool aNotify)
>  {
>    if (mType == NS_FORM_INPUT_RADIO) {
> +    if (mCheckedChanged != aCheckedChanged) {

ditto

@@ +3163,5 @@
>    
>    nsEventStates state = nsGenericHTMLFormElement::IntrinsicState();
>    if (mType == NS_FORM_INPUT_CHECKBOX || mType == NS_FORM_INPUT_RADIO) {
>      // Check current checked state (:checked)
> +    if (mChecked) {

ditto (with GetChecked() instead of GetCheckedChanged())

@@ +3320,5 @@
>    //
>    // For integrity purposes, we have to ensure that "checkedChanged" is
>    // the same for this new element as for all the others in the group
>    //
> +  bool checkedChanged = mCheckedChanged;

ditto

::: content/html/content/src/nsHTMLInputElement.h
@@ +597,5 @@
> +  /**
> +   * The type of this input (<input type=...>) as an integer.
> +   * @see nsIFormControl.h (specifically NS_FORM_INPUT_*)
> +   */
> +  PRUint8                  mType;

Would it make sense to add " : 8" here?

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4edb27f15750