679334 - LINK : fatal error LNK1266: error reading instrumentation file 'firefox.pgd'; File not found

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Armen [:armenzg]]

I am hitting this compilation error on the Windows 64-bit builds and is keeping the builds red.

nsBrowserApp.obj 
LINK : fatal error LNK1266: error reading instrumentation file 'firefox.pgd'; File not found
make[6]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/browser/app'
make[6]: *** [firefox.exe] Error 242
make[5]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox/browser'
make[4]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[5]: *** [libs] Error 2
make[4]: *** [libs_tier_app] Error 2
make[3]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[3]: *** [tier_app] Error 2
make[2]: *** [default] Error 2
make[2]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build/obj-firefox'
make[1]: Leaving directory `/e/builds/moz2_slave/m-cen-w64/build'
make[1]: *** [realbuild] Error 2
make: *** [profiledbuild] Error 2

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Probably related to Bug 669031 ...

Comment 2

[Mike Hommey [:glandium]]

It kind of partially looks like bug 678409, in that you somehow don't have profiling information, and the linker fails because of it, while it shouldn't.

Comment 3

[Mike Hommey [:glandium]]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #1)
> Probably related to Bug 669031 ...

Not quite, in that the file missing from bug 669031 is pretty much expected not to be there. Firefox.pgd being missing is not. Except if PROFILE_GEN_SCRIPT does nothing.

Comment 4

[Armen [:armenzg]]

I have also hit this in the last week:
"LINK : fatal error LNK1266: error reading instrumentation file 'plc4.pgd'; File not found"

If I disable PGO on win64 do you think it will make us complete the step?

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yes, because this step will never be run.

Comment 6

[Mike Hommey [:glandium]]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #4)
> I have also hit this in the last week:
> "LINK : fatal error LNK1266: error reading instrumentation file 'plc4.pgd';
> File not found"
> 
> If I disable PGO on win64 do you think it will make us complete the step?

You can also clobber.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Don't remove pgd files, but clear them with pgomgr instead

Comment 9

[Mike Hommey [:glandium]]

Attachment: Don't remove pgd files, but clear them with pgomgr instead. NSPR part

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 553458 [details] [diff] [review]
Don't remove pgd files, but clear them with pgomgr instead

Review of attachment 553458 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/rules.mk
@@ +903,5 @@
>  ifdef MOZ_PROFILE_GENERATE
>  # Clean up profiling data during PROFILE_GENERATE phase
>  export::
>  ifeq ($(OS_ARCH)_$(GNU_CC), WINNT_)
> +	-$(for pgd,$(wildcard *.pgd),pgomgr -clear $(pgd);)

ITYM $(foreach) here. Will this blow up if there are no pgd files present? (This will expand to just - then.)

Comment 11

[Mike Hommey [:glandium]]

Attachment: Don't remove pgd files, but clear them with pgomgr instead

Comment 12

[Mike Hommey [:glandium]]

Attachment: Don't remove pgd files, but clear them with pgomgr instead. NSPR part

Comment 13

[Armen [:armenzg]]

Clobbering did the job. Clobberer was not working on staging.

This is not a valid bug anymore but I see patches. Feel free to close it or whatever you feel is right.

Comment 14

[Armen [:armenzg]]

I have hit this again in production.

I have marked every builder to clobber since they could have objdirs from when they were connected to staging.

Comment 15

[(not currently active) Ted Mielczarek]

NSPR patch:
Checking in config/rules.mk;
/cvsroot/mozilla/nsprpub/config/rules.mk,v  <--  rules.mk
new revision: 3.82; previous revision: 3.81
done

Comment 16

[Mike Hommey [:glandium]]

http://hg.mozilla.org/projects/build-system/rev/e25c18bf42d2

Comment 17

[Mike Hommey [:glandium]]

http://hg.mozilla.org/projects/build-system/rev/14497b5c651e

Comment 18

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/e25c18bf42d2