679460 - runtest.py should warn when SOLO_TEST is empty

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jonathan Protzenko [:protz]]

I just wasted a couple minutes because I'm constantly confusing SOLO_FILE (xpcshell) and SOLO_TEST (mozmill), and I couldn't figure out why make mozmill-one would start up, run zero tests, and shutdown without complaining about anything. Would be good to have that at some point :-)

Comment 1

[Rain [:rain1] (inactive)]

Attachment: patch v1

The patch does three things:
- Supports both SOLO_TEST and SOLO_FILE as parameters.
- Errors out if both are present.
- Bonus: errors out if either's present with make mozmill. I've caught myself too many times writing SOLO_FILE=foo make mozmill.

Comment 2

[Rain [:rain1] (inactive)]

Mark, do you agree with what I'm doing here?

Comment 3

[Jonathan Protzenko [:protz]]

Comment on attachment 554506 [details] [diff] [review]
patch v1

My understanding of Makefilian is limited, but this looks right.

Comment 4

[Mark Banner (:standard8)]

Looking at the patch it seems reasonable, but it doesn't seem to fully address comment 0 which is that "make mozmill-one" should error out with a warning that you need to provide one of the parameters.

Comment 5

[Rain [:rain1] (inactive)]

Attachment: patch v2

right, fixed

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 558088 [details] [diff] [review]
patch v2

That's better, thanks.

Comment 7

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/comm-central/rev/e55763f24532