Closed Bug 679460 Opened 10 years ago Closed 10 years ago

runtest.py should warn when SOLO_TEST is empty

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: protz, Assigned: rain1)

Details

Attachments

(1 file, 1 obsolete file)

I just wasted a couple minutes because I'm constantly confusing SOLO_FILE (xpcshell) and SOLO_TEST (mozmill), and I couldn't figure out why make mozmill-one would start up, run zero tests, and shutdown without complaining about anything. Would be good to have that at some point :-)
Attached patch patch v1 (obsolete) — Splinter Review
The patch does three things:
- Supports both SOLO_TEST and SOLO_FILE as parameters.
- Errors out if both are present.
- Bonus: errors out if either's present with make mozmill. I've caught myself too many times writing SOLO_FILE=foo make mozmill.
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Attachment #554506 - Flags: review?(mbanner)
Attachment #554506 - Flags: feedback?(jonathan.protzenko)
Mark, do you agree with what I'm doing here?
Comment on attachment 554506 [details] [diff] [review]
patch v1

My understanding of Makefilian is limited, but this looks right.
Attachment #554506 - Flags: feedback?(jonathan.protzenko) → feedback+
Looking at the patch it seems reasonable, but it doesn't seem to fully address comment 0 which is that "make mozmill-one" should error out with a warning that you need to provide one of the parameters.
Attached patch patch v2Splinter Review
right, fixed
Attachment #554506 - Attachment is obsolete: true
Attachment #554506 - Flags: review?(mbanner)
Attachment #558088 - Flags: review?(mbanner)
Comment on attachment 558088 [details] [diff] [review]
patch v2

That's better, thanks.
Attachment #558088 - Flags: review?(mbanner) → review+
https://hg.mozilla.org/comm-central/rev/e55763f24532
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in before you can comment on or make changes to this bug.