679483 - Provide a way to disable this @!#$ rich failure logging that fills my terminal

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Jonathan Protzenko [:protz]]

Attachment: Patch v1

The title says it all.

Comment 1

[Rain [:rain1] (inactive)]

Hmm, I think this should be the other way round -- we shouldn't print rich failures unless we set an env var called (e.g.) MOZMILL_RICH_FAILURES. Then we can update buildbot and set the variable.

Comment 2

[Rain [:rain1] (inactive)]

Comment on attachment 553570 [details] [diff] [review]
Patch v1

yeah, let's do it the other way round unless you have an objection.

Comment 3

[Jonathan Protzenko [:protz]]

Yeah sure I just need to find the time to figure out how to talk to the buildbots so that they have the right env variable exported, that's all :)

Comment 4

[Jonathan Protzenko [:protz]]

Attachment: Patch v2

Comment 5

[Jonathan Protzenko [:protz]]

Attachment: Patch v3

Sorry, I'd left an extra print in there.

Comment 6

[Rain [:rain1] (inactive)]

Comment on attachment 554456 [details] [diff] [review]
Patch v3

Buildbot patches coming up. We'll need to get those in first.

Comment 7

[Rain [:rain1] (inactive)]

Attachment: patch to buildbotcustom-thunderbird

Comment 8

[Rain [:rain1] (inactive)]

Attachment: patch to buildbotcustom-thunderbird-try

Comment 9

[Rain [:rain1] (inactive)]

Oh, so you need to define USE_RICH_FAILURES on top as None so that if that code doesn't get run (due to an error perhaps) then python doesn't complain even further about USE_RICH_FAILURES not being defined.

Comment 10

[Rain [:rain1] (inactive)]

... as None or False.

Comment 11

[Jonathan Protzenko [:protz]]

Attachment: Patch v4

Do you want to check this in at the same time you update the build bots? (I don't know if that's the same repo or not).

Comment 12

[Rain [:rain1] (inactive)]

It doesn't need to be simultaneous -- the buildbots can go first, since all we're doing is setting a currently unrecognized envvar.

Comment 13

[Rain [:rain1] (inactive)]

Mark, gozer, could we get the buildbot patches in sometime?

Comment 14

[John Hopkins (:jhopkins)]

buildbot patches (thanks!) have been applied to production, try, and try-unittest.  these buildbot instances have been reconfig'd to make the changes live.
Now you just need to apply Patch v4 to the tree(s)

Comment 15

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/0056c230da57