679825 - Spidermonkey.sh needs to pass "--enable-64bit" to nspr configure when building for 64bit target

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

...because nspr builds 32bit by default even for 64bit targetting builds.  Why, I have no clue.  http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#336

The change is likely going to be to be around

http://hg.mozilla.org/build/tools/file/default/scripts/spidermonkey_builds/spidermonkey.sh#l81

Comment 1

[[e-mail] (:bhearsum)]

Shouldn't the SpiderMonkey build system take care of this?

Comment 2

[John Ford [:jhford] CET/CEST Berlin Time]

Spidermonkey doesn't know how to build nspr, so we have to build it ourselves in spidermonkey.sh.  I wonder if it'd be useful to add some sort of '--with-build-nspr' to the JS configuration.

Comment 3

[Phil Ringnalda (:philor)]

That'd be bug 625895, good luck.

Comment 4

[Phil Ringnalda (:philor)]

I'd also find this more persuasive if I could reproduce the SpiderMonkey failure, but when I build the same way as spidermonkey.sh, I don't get nspr detecting i386-apple-darwin10, and I don't get a 32-bit nspr, even without --enable-64bit.

Comment 5

[Chris Cooper [:coop] (he/him)]

Attachment: Pass --enable-64bit to nspr for spidermonkey on darwin10

This is the quickest fix I could verify. Spidermonkey builds (and tests) correctly with this patch on darwin10.

We'll need to extend and/or change this for building on lion (bug 745300), but this should let us shut off the darwin9 builders at least.

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Comment on attachment 614940 [details] [diff] [review]
Pass --enable-64bit to nspr for spidermonkey on darwin10

http://hg.mozilla.org/build/tools/rev/ffbd343f369e

Comment 7

[Phil Ringnalda (:philor)]

Good to see this finally get tested, so we can look at doing other things instead.

https://tbpl.mozilla.org/php/getParsedLog.php?id=10895461&tree=Mozilla-Inbound&full=1 is with this, passing --enable-64bit, still getting identified as i386-apple-darwin10.2.0, still building 32-bit, and still not running.

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to Phil Ringnalda (:philor) from comment #7)
> Good to see this finally get tested, so we can look at doing other things
> instead.
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=10895461&tree=Mozilla-
> Inbound&full=1 is with this, passing --enable-64bit, still getting
> identified as i386-apple-darwin10.2.0, still building 32-bit, and still not
> running.

These just needed a clobber.