Spidermonkey.sh needs to pass "--enable-64bit" to nspr configure when building for 64bit target

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
7 years ago
14 days ago

People

(Reporter: jhford, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [spidermonkey])

Attachments

(1 attachment)

...because nspr builds 32bit by default even for 64bit targetting builds.  Why, I have no clue.  http://mxr.mozilla.org/mozilla-central/source/nsprpub/configure.in#336

The change is likely going to be to be around

http://hg.mozilla.org/build/tools/file/default/scripts/spidermonkey_builds/spidermonkey.sh#l81
Blocks: 678435
Blocks: 674647
Shouldn't the SpiderMonkey build system take care of this?
Spidermonkey doesn't know how to build nspr, so we have to build it ourselves in spidermonkey.sh.  I wonder if it'd be useful to add some sort of '--with-build-nspr' to the JS configuration.
That'd be bug 625895, good luck.
Depends on: 625895
Priority: -- → P3
I'd also find this more persuasive if I could reproduce the SpiderMonkey failure, but when I build the same way as spidermonkey.sh, I don't get nspr detecting i386-apple-darwin10, and I don't get a 32-bit nspr, even without --enable-64bit.
Component: Release Engineering → Release Engineering: Automation
QA Contact: release → catlee
(Assignee)

Updated

6 years ago
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: P3 → P2
Hardware: x86 → x86_64
Whiteboard: [spidermonkey]
(Assignee)

Comment 5

6 years ago
Created attachment 614940 [details] [diff] [review]
Pass --enable-64bit to nspr for spidermonkey on darwin10

This is the quickest fix I could verify. Spidermonkey builds (and tests) correctly with this patch on darwin10.

We'll need to extend and/or change this for building on lion (bug 745300), but this should let us shut off the darwin9 builders at least.
Attachment #614940 - Flags: review?(jhford)
Attachment #614940 - Flags: review?(jhford) → review+
Comment on attachment 614940 [details] [diff] [review]
Pass --enable-64bit to nspr for spidermonkey on darwin10

http://hg.mozilla.org/build/tools/rev/ffbd343f369e
Attachment #614940 - Flags: checked-in+
Good to see this finally get tested, so we can look at doing other things instead.

https://tbpl.mozilla.org/php/getParsedLog.php?id=10895461&tree=Mozilla-Inbound&full=1 is with this, passing --enable-64bit, still getting identified as i386-apple-darwin10.2.0, still building 32-bit, and still not running.
(Assignee)

Comment 8

6 years ago
(In reply to Phil Ringnalda (:philor) from comment #7)
> Good to see this finally get tested, so we can look at doing other things
> instead.
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=10895461&tree=Mozilla-
> Inbound&full=1 is with this, passing --enable-64bit, still getting
> identified as i386-apple-darwin10.2.0, still building 32-bit, and still not
> running.

These just needed a clobber.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 739994
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.