Closed Bug 745300 Opened 11 years ago Closed 11 years ago

Do Mac spidermonkey builds on 10.7

Categories

(Release Engineering :: General, defect, P2)

x86_64
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: coop, Assigned: coop)

Details

(Whiteboard: [spidermonkey][10.7])

Attachments

(3 files)

We should enable these jobs on the new lion minis (10.7) This will allow us to turn off these builds on 10.6 and 10.5.

This could either be blocked on bug 678435 and bug 679825, or it might obviate the need for them.
Priority: -- → P3
Assignee: nobody → coop
Status: NEW → ASSIGNED
Priority: P3 → P2
Hardware: x86 → x86_64
spidermonkey builds fine on lion. I have a suite of patches that turn this on (and disable it on 10.6), but I want to talk with jhford about how I've implemented it to make sure it meshes with how we're planning to remove 10.6 support more generally (except for esr10, etc.).
This is the most important patch of the bunch, as I mentioned in our 1x1 yesterday. Because of the way projects create their branch objects, we need a separate set of PLATFORM_VARS for lion.
Attachment #618735 - Flags: review?(jhford)
Attachment #618733 - Flags: review?(jhford) → review+
Attachment #618735 - Flags: review?(jhford) → review+
Comment on attachment 618737 [details] [diff] [review]
Tools changes to do spidermonkey builds on 10.7

Review of attachment 618737 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/spidermonkey_builds/spidermonkey.sh
@@ +61,5 @@
>  
>  CONFIGURE_ARGS=$(cat $SPIDERDIR/$VARIANT)
>  
>  NSPR64=""
> +if [[ "$OSTYPE" == darwin* ]]; then

Did you mean to use a case?

$ OSTYPE=darwin11
$ if [ $OSTYPE == darwin11 ] ; then echo Equal ; fi
Equal
$ if [ $OSTYPE == darwin* ] ; then echo Equal ; fi
$ case $OSTYPE in
> darwin*)
>   echo Mac
>   ;;
> *)
>   echo Not-mac
>  ;;
> esac
Mac

$ OSTYPE=lala
$ case $OSTYPE in darwin*)   echo Mac;   ;; *)   echo Not-mac;  ;; esac
Not-mac
Attachment #618737 - Flags: review?(jhford) → review-
Comment on attachment 618737 [details] [diff] [review]
Tools changes to do spidermonkey builds on 10.7

nope, my test wasn't valid

$ if [[ $OSTYPE == darwin* ]] ; then echo Equal ; fi
Equal
Attachment #618737 - Flags: review- → review+
Comment on attachment 618737 [details] [diff] [review]
Tools changes to do spidermonkey builds on 10.7

https://hg.mozilla.org/build/tools/rev/9128c8cc0f16
Attachment #618737 - Flags: checked-in+
Comment on attachment 618733 [details] [diff] [review]
Buildbotcustom changes to do spidermonkey builds on 10.7.

https://hg.mozilla.org/build/buildbotcustom/rev/03badc6c513e
Attachment #618733 - Flags: checked-in+
Comment on attachment 618735 [details] [diff] [review]
Config changes to do spidermonkey builds on 10.7

https://hg.mozilla.org/build/buildbot-configs/rev/58b18a8bf6e8
Attachment #618735 - Flags: checked-in+
Merged to production
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.