The default bug view has changed. See this FAQ.

switching from private browsing does not show panorama if it was open before

RESOLVED FIXED in Firefox 9

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 9

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
STR:

1) have two tabs
2) select the second tab
3) go into panorama
4) enter private browsing
5) go into panorama
6) leave private browsing

Expected result: Panorama is shown.
Actual result: Panorama is not shown.

This is because the PB service sets an intermediate browser state before switching to PB mode completely (see bug 476463). This issues a TabSelect event which zooms out of Panorama (possibly a regression since bug 633190).
(Assignee)

Comment 1

6 years ago
Created attachment 553886 [details] [diff] [review]
[checked-in] patch v1
(Assignee)

Comment 2

6 years ago
Comment on attachment 553886 [details] [diff] [review]
[checked-in] patch v1

Review of attachment 553886 [details] [diff] [review]:
-----------------------------------------------------------------

Is this a good way to tell a reviewer what my patch does? Let's try...

::: browser/base/content/tabview/ui.js
@@ -718,5 @@
>        } else if (topic == "private-browsing-change-granted") {
>          if (data == "enter" || data == "exit") {
>            hideSearch();
>            self._privateBrowsing.transitionMode = data;
> -          self.storageBusy();

This can be removed because UI._storageBusy is only a flag, not a counter anymore (since bug 662812). The SSWindowStateReady/Busy events will be fired by the setBrowserState() calls the private browsing service issues.

@@ -732,5 @@
>              self._privateBrowsing.wasInTabView)
>            self.showTabView(false);
>  
>          self._privateBrowsing.transitionMode = "";
> -        self.storageReady();

(see above)

@@ +886,5 @@
>      this._currentTab = tab;
>  
>      if (this.isTabViewVisible()) {
> +      if (!this.restoredClosedTab && !this._privateBrowsing.transitionMode &&
> +          this._lastOpenedTab == tab && tab._tabViewTabItem) {

If we're in the middle of a private browsing mode transition we don't want to zoom into a tab.
Attachment #553886 - Flags: feedback?(raymond)
Comment on attachment 553886 [details] [diff] [review]
[checked-in] patch v1

Seems to be a good way to explain what a patch does.
Attachment #553886 - Flags: feedback?(raymond) → feedback+
(Assignee)

Updated

6 years ago
Attachment #553886 - Flags: review?(dietrich)
Comment on attachment 553886 [details] [diff] [review]
[checked-in] patch v1

Review of attachment 553886 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the explanations, it *definitely* helps. r=me.

::: browser/base/content/tabview/ui.js
@@ +886,5 @@
>      this._currentTab = tab;
>  
>      if (this.isTabViewVisible()) {
> +      if (!this.restoredClosedTab && !this._privateBrowsing.transitionMode &&
> +          this._lastOpenedTab == tab && tab._tabViewTabItem) {

there are a bunch of other conditions in there - some are self-documenting and some aren't. can you add a comment here that clearly explains the conditions for zoom in to occur?
Attachment #553886 - Flags: review?(dietrich) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/integration/fx-team/rev/e138c3a22a65
Whiteboard: [fixed-in-fx-team]
Comment on attachment 553886 [details] [diff] [review]
[checked-in] patch v1

http://hg.mozilla.org/mozilla-central/rev/e138c3a22a65
Attachment #553886 - Attachment description: patch v1 → [checked-in] patch v1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 9
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.