679869 - Ensure deleting addons doesn't mess up receipts

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Andy McKay]

Depends upon other things being done first, but when the app store and the marketplace is all complete we'll need to ensure that when a user deletes an add-on from AMO that:

- no new app receipts can be issued, but pre-existing app receipts can be re-issued.

- watermarking checks on update still works as expected and does nothing wierd.

- the transactions are still in the users transaction log so that they can see the payments and refunds.

Comment 1

[Andy McKay]

I think we should soft delete premium addons. Partly because then everything else is easy.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #1)
> I think we should soft delete premium addons. Partly because then everything
> else is easy.

wfm

Comment 3

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/a1a2345

soft delete == disabled_by_user.

True db deletes are allowed for incomplete addons/apps still.  The assumption being that these never made it to the public pages for installation and are safe to be deleted at the db level.