680227 - Add support for Wintaskbar pre Windows 7

Status: RESOLVED WONTFIX

(Core :: Widget: Win32, defect)

Description

[Brian R. Bondy [:bbondy]]

Our current implementation of Wintaskbar requires Windows 7 to actually create the object.
This is because it supports ITaskbarList3 and ITaskbarList4 

However we use some functions from ITaskbarList which only requires Windows 2000 (ActivateTab) and ITaskbarList2 (MarkFullScreenWindow) which only requires Windows XP.

It would be good to be able to get a scaled down version of the taskbar for the code that can still benefit from it when that code is running pre Windows 7.

I think the best way to handle this would be to have 3 classes that implement nsIWintaskbar.  The Windows 2000 one will have the base code, the Windows XP one will inherit from the Windows 2000 one and add some stuff.  The Windows 7 one will inherit from the Windows XP one and add more.  All would use the same interface but the Windows 2000 and Windows XP ones would return not implemented errors for the calls that are not available.

Comment 1

[Jim Mathies [:jimm]]

I would waste any time on 2000 related support, unless we need that as a base class for the rest.

Comment 2

[Brian R. Bondy [:bbondy]]

> I would waste any time on 2000 related support

OK will [not] do, definitely worth it for the Win XP support though especially for Bug 617052.
 
Regarding my original post...
The task is to:
1) Remove conditionals for Win7 only.
2) Add another XPIDL interface that is for XP support items
3) Have the normal nsIWinTaskbar inherit from that interface.
4) Refactor whatever code is needed to do all of this, for example make sure we have NULL checks when we request the Win7 only interface.

Comment 3

[harshil goel]

i would like to would to work on this bug, can you tell me how to start

Comment 4

[Brian R. Bondy [:bbondy]]

Sorry for the inconvenience, but after reading this through again I think there's no clear benefit to doing it and it could introduce regressions. Also our min version will eventually change again so it's not worth it.  So I'm going to wontfix this.  If anyone has strong objections please feel free to re-open.