680280 - Tools -> Web Search does nothing when the sidebar is displayed

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[jwq]

Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20110813 Firefox/6.0 SeaMonkey/2.3

There seems to be a recently-introduced conflict between the sidebar which was introduced in the 2.2 release. If the sidebar is shown [View -> Show/Hide -> Sidebar (F9)] then Tools -> Web Search (Ctrl+Shift+S) does nothing. There's no errors on the error console. If the sidebar is hidden then Tools -> Web Search (Ctrl+Shift+S) correctly calls the default search engine.

Steps to reproduce:
1. Show sidebar: View -> Show/Hide -> Sidebar (F9)
2. Choose Web Search: Tools -> Web Search (Ctrl+Shift+S)

Actual Result:
No visible action in browser window

Expected Result:
Default search engine page is displayed.

Comment 1

[jwq]

Possibly related to Bug 601466?

Comment 2

[Ian Neal]

The issue is that when the sidebar is open the code tries to do (even if the search panel isn't the one currently open)
this.searchSidebar.focus();
See http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#1176
Not sure what this is supposed to do, but it does not appear to do anything on current trunk.

If you customise the sidebar to remove the search panel then it will either focus the search bar if present or open the relevant search engine's web page (as expected).

Comment 3

[[e-mail]]

Attachment: Possible patch

I thought that the previous code was focusing the search sidebar content, but it's not, so this just finds the sidebar search box more directly.

Comment 4

[Ian Neal]

Comment on attachment 554251 [details] [diff] [review]
Possible patch

r=me, a=me for comm-aurora/beta
Requesting for comm-release to see if we can get it into 2.3.1

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 554251 [details] [diff] [review]
Possible patch

Unless its a change we would respin an rc for in the old cycle, I don't want to take it for .1, sorry.

Comment 6

[[e-mail]]

Pushed changeset d4f82c11ebaf to comm-central only.

Comment 7

[Philip Chee]

Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/af1001813b05
http://hg.mozilla.org/releases/comm-beta/rev/bf59bac2d8c4