680425 - Tapping on a selected word does not copy the word to clipboard

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110819
Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2

Steps to reproduce:
1. Open Fennec App
2. Visit the website: http://en.wikipedia.org/wiki/Mozilla
3. In the first introductory paragraph, tap press-hold on a selected word such as: Mozilla 
4. Tap on the text selection

Expected result:
On second tap, the selected word is copied to clipboard and the user is notified of this action via a toaster notification

Actual result:
The toaster notification is not displayed and the selected word is not copied to clipboard.

Comment 1

[Aaron Train [:aaronmt]]

This is probably a regression from bug 666977 (http://hg.mozilla.org/mozilla-central/rev/00f9b3304811).

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #1)
> This is probably a regression from bug 666977
> (http://hg.mozilla.org/mozilla-central/rev/00f9b3304811).

that would have made sense, but I just did a build with changeset e204fcdf5049 and copying to the clipboard is also broken there. A regression window would be very useful here. Is this also broken on Aurora?

Comment 3

[Aaron Train [:aaronmt]]

Last known good - 
20110818030747
http://hg.mozilla.org/mozilla-central/rev/f69a10f23bf3

First known bad -
20110819030749
http://hg.mozilla.org/mozilla-central/rev/1881f9b5f8b5

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f69a10f23bf3&tochange=1881f9b5f8b5

(In reply to Brad Lassey [:blassey][[e-mail]] from comment #2)
> (In reply to Aaron Train [:aaronmt] from comment #1)
> Is this also broken on Aurora?

No.

Comment 4

[Matt Brubeck (:mbrubeck)]

(In reply to Brad Lassey [:blassey][[e-mail]] from comment #2)
> that would have made sense, but I just did a build with changeset
> e204fcdf5049 and copying to the clipboard is also broken there.

Are you sure?  Backing out 00f9b3304811 (bug 666977) from m-c tip fixes this for me in a desktop build.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

no, I'm not sure. I thought tapping anywhere would copy the text as opposed to tapping on the selection

Comment 6

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Just some simple breakage fixes.  Sorry for not catching these in review of bug 666977.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92c74d08dcdb

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/92c74d08dcdb

Comment 9

[Catalin Suciu [:csuciu]]

The bug is verified as fixed on Build id : Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110822 Firefox/9.0a1 Fennec/9.0a1
Device: HTC Desire
OS: Android 2.2