Last Comment Bug 680488 - QFeedBack include is not needed for geolocation provider file
: QFeedBack include is not needed for geolocation provider file
Status: RESOLVED FIXED
:
Product: Core Graveyard
Classification: Graveyard
Component: Widget: Qt (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla9
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks: 679236
  Show dependency treegraph
 
Reported: 2011-08-19 10:55 PDT by Oleg Romashin (:romaxa)
Modified: 2016-07-11 21:54 PDT (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove wrong include (662 bytes, patch)
2011-08-19 10:56 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
Remove wrong include, and fix CHECK_LIB usage (1.88 KB, patch)
2011-08-20 15:01 PDT, Oleg Romashin (:romaxa)
doug.turner: review+
Details | Diff | Splinter Review

Description Oleg Romashin (:romaxa) 2011-08-19 10:55:35 PDT
http://hg.mozilla.org/mozilla-central/file/default/dom/system/unix/QTMLocationProvider.cpp#l40

This was added by mistake.
Comment 1 Oleg Romashin (:romaxa) 2011-08-19 10:56:57 PDT
Created attachment 554472 [details] [diff] [review]
Remove wrong include

My bad, did not cleanup patch properly
Comment 2 Oleg Romashin (:romaxa) 2011-08-20 15:01:22 PDT
Created attachment 554674 [details] [diff] [review]
Remove wrong include, and fix CHECK_LIB usage


checking for QtSensors QtFeedback QtLocation... checking for main in -lQtSensors QtFeedback QtLocation... eval: 1: Bad substitution

Patch also fixing this problem
Comment 3 Ed Morley [:emorley] 2011-08-23 04:08:26 PDT
In my queue, which is being sent to try and then presuming green, I'll land on inbound later today.
Comment 5 Marco Bonardo [::mak] 2011-08-24 01:38:28 PDT
http://hg.mozilla.org/mozilla-central/rev/00e6b254d211

Note You need to log in before you can comment on or make changes to this bug.