QFeedBack include is not needed for geolocation provider file

RESOLVED FIXED in mozilla9

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla9
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
http://hg.mozilla.org/mozilla-central/file/default/dom/system/unix/QTMLocationProvider.cpp#l40

This was added by mistake.
(Assignee)

Comment 1

6 years ago
Created attachment 554472 [details] [diff] [review]
Remove wrong include

My bad, did not cleanup patch properly
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #554472 - Flags: review?(doug.turner)
(Assignee)

Comment 2

6 years ago
Created attachment 554674 [details] [diff] [review]
Remove wrong include, and fix CHECK_LIB usage


checking for QtSensors QtFeedback QtLocation... checking for main in -lQtSensors QtFeedback QtLocation... eval: 1: Bad substitution

Patch also fixing this problem
Attachment #554472 - Attachment is obsolete: true
Attachment #554472 - Flags: review?(doug.turner)
Attachment #554674 - Flags: review?(doug.turner)

Updated

6 years ago
Attachment #554674 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 3

6 years ago
In my queue, which is being sent to try and then presuming green, I'll land on inbound later today.
Keywords: checkin-needed

Comment 4

6 years ago
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=e3f0e5b06e77

http://hg.mozilla.org/integration/mozilla-inbound/rev/00e6b254d211
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/00e6b254d211
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.