Add Maemo6 geolocation provider (Qt Mobility based)

RESOLVED FIXED in mozilla9

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla9
ARM
Maemo
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 3 obsolete attachments)

This must be available in Maemo6 fennec.
Posted patch Maemo6 Geolocation provider (obsolete) — Splinter Review
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #553324 - Flags: review?(doug.turner)
Posted patch Maemo6 Geolocation provider (obsolete) — Splinter Review
Minor correction, we can use same request for all access
Attachment #553324 - Attachment is obsolete: true
Attachment #553324 - Flags: review?(doug.turner)
Attachment #553333 - Flags: review?(doug.turner)
Comment on attachment 553333 [details] [diff] [review]
Maemo6 Geolocation provider

missing QTMLocationProvider*
Attachment #553333 - Flags: review?(doug.turner) → review-
Posted patch Maemo6 Geolocation provider (obsolete) — Splinter Review
Ups, forgot hg add ...
Attachment #553333 - Attachment is obsolete: true
Attachment #553343 - Flags: review?(doug.turner)
Comment on attachment 553343 [details] [diff] [review]
Maemo6 Geolocation provider

Review of attachment 553343 [details] [diff] [review]:
-----------------------------------------------------------------

fix the dates, and explain the playThemeEffect.  other than that, looks good.

::: dom/system/unix/QTMLocationProvider.cpp
@@ +14,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

@@ +87,5 @@
> +
> +NS_IMETHODIMP
> +QTMLocationProvider::Startup()
> +{
> +    QFeedbackEffect::playThemeEffect(QFeedbackEffect::ThemeBasicButton);

what does this do?

::: dom/system/unix/QTMLocationProvider.h
@@ +13,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011
Attachment #553343 - Flags: review?(doug.turner) → review+
Keywords: checkin-needed
Also this patch need to be landed together with patch from bug 673395
Attachment #553343 - Attachment is obsolete: true
Attachment #553396 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/690b443ea689
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Depends on: 680488
You need to log in before you can comment on or make changes to this bug.