679236 - Add Maemo6 geolocation provider (Qt Mobility based)

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Oleg Romashin (:romaxa)]

This must be available in Maemo6 fennec.

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Maemo6 Geolocation provider

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Maemo6 Geolocation provider

Minor correction, we can use same request for all access

Comment 3

[Doug Turner (:dougt)]

Comment on attachment 553333 [details] [diff] [review]
Maemo6 Geolocation provider

missing QTMLocationProvider*

Comment 4

[Oleg Romashin (:romaxa)]

Attachment: Maemo6 Geolocation provider

Ups, forgot hg add ...

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 553343 [details] [diff] [review]
Maemo6 Geolocation provider

Review of attachment 553343 [details] [diff] [review]:
-----------------------------------------------------------------

fix the dates, and explain the playThemeEffect.  other than that, looks good.

::: dom/system/unix/QTMLocationProvider.cpp
@@ +14,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

@@ +87,5 @@
> +
> +NS_IMETHODIMP
> +QTMLocationProvider::Startup()
> +{
> +    QFeedbackEffect::playThemeEffect(QFeedbackEffect::ThemeBasicButton);

what does this do?

::: dom/system/unix/QTMLocationProvider.h
@@ +13,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Fixed comments, to push

Also this patch need to be landed together with patch from bug 673395

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/690b443ea689

Comment 8

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/690b443ea689