Add Maemo6 geolocation provider (Qt Mobility based)

RESOLVED FIXED in mozilla9

Status

()

Core
Geolocation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla9
ARM
Maemo
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

6 years ago
This must be available in Maemo6 fennec.
(Assignee)

Comment 1

6 years ago
Created attachment 553324 [details] [diff] [review]
Maemo6 Geolocation provider
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Attachment #553324 - Flags: review?(doug.turner)
(Assignee)

Comment 2

6 years ago
Created attachment 553333 [details] [diff] [review]
Maemo6 Geolocation provider

Minor correction, we can use same request for all access
Attachment #553324 - Attachment is obsolete: true
Attachment #553324 - Flags: review?(doug.turner)
Attachment #553333 - Flags: review?(doug.turner)

Comment 3

6 years ago
Comment on attachment 553333 [details] [diff] [review]
Maemo6 Geolocation provider

missing QTMLocationProvider*
Attachment #553333 - Flags: review?(doug.turner) → review-
(Assignee)

Comment 4

6 years ago
Created attachment 553343 [details] [diff] [review]
Maemo6 Geolocation provider

Ups, forgot hg add ...
Attachment #553333 - Attachment is obsolete: true
Attachment #553343 - Flags: review?(doug.turner)

Comment 5

6 years ago
Comment on attachment 553343 [details] [diff] [review]
Maemo6 Geolocation provider

Review of attachment 553343 [details] [diff] [review]:
-----------------------------------------------------------------

fix the dates, and explain the playThemeEffect.  other than that, looks good.

::: dom/system/unix/QTMLocationProvider.cpp
@@ +14,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

@@ +87,5 @@
> +
> +NS_IMETHODIMP
> +QTMLocationProvider::Startup()
> +{
> +    QFeedbackEffect::playThemeEffect(QFeedbackEffect::ThemeBasicButton);

what does this do?

::: dom/system/unix/QTMLocationProvider.h
@@ +13,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011
Attachment #553343 - Flags: review?(doug.turner) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Created attachment 553396 [details] [diff] [review]
Fixed comments, to push

Also this patch need to be landed together with patch from bug 673395
Attachment #553343 - Attachment is obsolete: true
Attachment #553396 - Flags: review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/690b443ea689
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/690b443ea689
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Assignee)

Updated

6 years ago
Depends on: 680488
You need to log in before you can comment on or make changes to this bug.