Closed Bug 679236 Opened 12 years ago Closed 12 years ago

Add Maemo6 geolocation provider (Qt Mobility based)

Categories

(Core :: DOM: Geolocation, defect)

Product:
Core
Component:
DOM: Geolocation
Platform:
ARM
Maemo
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file, 3 obsolete files)

Fixed comments, to push
10.12 KB, patch
romaxa
: review+
Details | Diff | Splinter Review 
This must be available in Maemo6 fennec.
Attached patch Maemo6 Geolocation provider (obsolete) — — Splinter Review 
Assignee: nobody → romaxa
Status: NEW → ASSIGNED

        Attachment #553324 -
        Flags: review?(doug.turner)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Maemo6 Geolocation provider (obsolete)
        — 
          — Splinter Review
      

    


  
Minor correction, we can use same request for all access

        Attachment #553324 -
        Attachment is obsolete: true

        Attachment #553324 -
        Flags: review?(doug.turner)

        Attachment #553333 -
        Flags: review?(doug.turner)

    
    

    
  
Comment on attachment 553333 [details] [diff] [review]
Maemo6 Geolocation provider

missing QTMLocationProvider*

        Attachment #553333 -
        Flags: review?(doug.turner) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Maemo6 Geolocation provider (obsolete)
        — 
          — Splinter Review
      

    


  
Ups, forgot hg add ...

        Attachment #553333 -
        Attachment is obsolete: true

        Attachment #553343 -
        Flags: review?(doug.turner)

    
    

    
  
Comment on attachment 553343 [details] [diff] [review]
Maemo6 Geolocation provider

Review of attachment 553343 [details] [diff] [review]:
-----------------------------------------------------------------

fix the dates, and explain the playThemeEffect.  other than that, looks good.

::: dom/system/unix/QTMLocationProvider.cpp
@@ +14,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

@@ +87,5 @@
> +
> +NS_IMETHODIMP
> +QTMLocationProvider::Startup()
> +{
> +    QFeedbackEffect::playThemeEffect(QFeedbackEffect::ThemeBasicButton);

what does this do?

::: dom/system/unix/QTMLocationProvider.h
@@ +13,5 @@
> + *
> + * The Original Code is Mozilla Qt code.
> + *
> + * The Initial Developer of the Original Code is Mozilla Foundation.
> + * Portions created by the Initial Developer are Copyright (C) 2010

2011

        Attachment #553343 -
        Flags: review?(doug.turner) → review+

    
  
Keywords: checkin-needed

    
    

    
  


  
Also this patch need to be landed together with patch from bug 673395

        Attachment #553343 -
        Attachment is obsolete: true

        Attachment #553396 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/690b443ea689
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9

    
  
Depends on: 680488

          You need to log in
          before you can comment on or make changes to this bug.