680511 - Consolidate checkspelling key into editorOverlay.xul

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Ian Neal]

Attachment: De-dupe checkspelling key [Checked in: Comment 2]

There is a key for checkspelling in both editorOverlay.xul and messengercompose.xul, they could be consolidated into a single one in editorOverlay.xul

This patch:
* Removes key_checkspelling from messengercompose.xul and its associated entity from messengercompose.dtd
* Renames checkspellingkb to key_checkspelling and associated references in editorOverlay.xul
* Removes unneeded disabled attribute from key, menuitem and toolbarbutton in editorOverlay.xul
* Removes JS code for enablement of above xul in editor.js as already done in isCommandEnabled code.

Comment 1

[[e-mail]]

Comment on attachment 554489 [details] [diff] [review]
De-dupe checkspelling key [Checked in: Comment 2]

>     HideItem("spellingButton");
>     HideItem("menu_checkspelling");
>     RemoveItem("sep_checkspelling");
I guess there was no point disabling them if they'll get hidden anyway ;-)

Comment 2

[Ian Neal]

Comment on attachment 554489 [details] [diff] [review]
De-dupe checkspelling key [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/e244d8761146