680559 - Unable to upload a webapp with kanji characters in its name

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Developer Pages, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.allizom.org/en-US/developers/addon/submit/2
2. Upload a webapp with kanji characters

expected behavior:
upload is successful

actual behavior:
upload fails with "Webapp: JSON Parse Error". See https://addons.allizom.org/en-US/developers/upload/8c43b8f130da41d79d819b7193a7db82

Comment 1

[David Chan [:dchan]]

krupa: Can you attach the webapp to the bug?

I think the fix may be to wrap the package reading with
codecs.open(file, mode="r", encoding="utf-8")

Comment 2

[Wil Clouser [:clouserw]]

It's not worth testing the upload support - that's going away shortly (bug already filed).  The web based retrieval is where it's at.

(That said, this may still be a valid bug)

Comment 3

[Matt Basta [:basta]]

dchan: There's a better way in the validator. We have a detection module called unicodehelper that should clean it up.

I'm interested to know whether AMO will handle more than 100 bytes, since the spec limits to 100 characters.

Comment 4

[Kumar McMillan [:kumar]]

According to the json spec encoding can be in escaped Unicode otherwise it defaults to utf8.  I'd need to take a look at the test-kanji.webapp file to know what's going on.  We might also need to pay attention to the charset header in the http response when parsing manifest URLs.

Comment 5

[Kumar McMillan [:kumar]]

Krupa, can you upload test-kanji.webapp so I can reproduce?  I'll be testing submission with manifest URL.

Comment 6

[krupa raj[:krupa]]

Upload works with kanji characters in the manifest. Closing the bug.