Closed Bug 680792 Opened 8 years ago Closed 8 years ago

Remove support for Irix from our build system

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: matjk7, Assigned: matjk7)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Attached patch patch (obsolete) — Splinter Review
Attachment #554750 - Flags: review?(ted.mielczarek)
Blocks: 680793
Is there no Gecko being run on Irix, then?  Or will it still be possible to try to build on Irix, just without any of the special-casing?
It won't be possible to build Firefox under Irix/mips after this patch lands, but my understanding is that the platform is dead so there's no reason to keep this code around.
Comment on attachment 554750 [details] [diff] [review]
patch

Review of attachment 554750 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/hcpp
@@ -96,1 @@
>  			;;

I think this whole hcpp wrapper can probably die. AFAICT from configure, it's only for compilers that don't support "-c -o" at the same time, which is pretty old.

::: xpcom/reflect/xptcall/src/md/unix/Makefile.in
@@ -291,5 @@
> -#
> -ifeq ($(OS_ARCH),IRIX)
> -ifneq ($(basename $(OS_RELEASE)),5)
> -CPPSRCS		:= xptcinvoke_irix.cpp xptcstubs_irix.cpp
> -ASFILES		:= xptcinvoke_asm_irix.s xptcstubs_asm_irix.s

I'd guess you should hg rm these files while you're here.
Attachment #554750 - Flags: review?(ted.mielczarek) → review+
Updated to tip.

(In reply to Ted Mielczarek [:ted, :luser] from comment #4)
> I think this whole hcpp wrapper can probably die. AFAICT from configure,
> it's only for compilers that don't support "-c -o" at the same time, which
> is pretty old.

I'll remove hcpp in a follow-up bug.

> I'd guess you should hg rm these files while you're here.

Bug 680793.
Attachment #554750 - Attachment is obsolete: true
Attachment #555881 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/projects/build-system/rev/a80fe3a6586f

Be gone crufty code! :-)
Keywords: checkin-needed
Whiteboard: fixed-in-bs
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/a80fe3a6586f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 682751
Blocks: 807488
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.