Closed Bug 682751 Opened 8 years ago Closed 8 years ago

Remove build/hcc and build/hcpp

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: matjk7, Assigned: matjk7)

References

Details

(Whiteboard: fixed-in-bs)

Attachments

(2 files, 1 obsolete file)

patch for checkin
9.96 KB, patch
matjk7
: review+
Details | Diff | Splinter Review
bustage fix
6.87 KB, patch
Details | Diff | Splinter Review 
No description provided.
Flags: in-testsuite-
Attached patch patch (obsolete) — — Splinter Review 
From a quick look in MXR it appears that Unixware depends on this workaround. Are we ok with dropping support for that platform?
Attachment #556439 - Flags: review?(ted.mielczarek)
Comment on attachment 556439 [details] [diff] [review]
patch

Review of attachment 556439 [details] [diff] [review]:
-----------------------------------------------------------------

If UnixWare really relies on this then yes, it's fine to drop support. (I'd bet that's probably an ancient workaround anyway.)

::: configure.in
@@ +946,5 @@
>  esac
>  
>  dnl Test breaks icc on OS/2 && MSVC
>  if test "$CC" != "icc" -a -z "$_WIN32_MSVC"; then
>      AC_PROG_CC_C_O

Just remove this whole block. It's not worth testing for compilers that can't support -c -o at all.
Attachment #556439 - Flags: review?(ted.mielczarek) → review+
Blocks: 682920
Attachment #556439 - Attachment is obsolete: true
Attachment #556630 - Flags: review+
Attachment #556630 - Flags: checkin?(bmo)
Attachment #556630 - Flags: checkin?(bmo) → checkin+
Target Milestone: --- → mozilla9
Attached patch bustage fix — — Splinter Review 
Maybe one day I'll actually remember to change js/src before burning the tree.
Attachment #556656 - Flags: checkin?(bmo)
Comment on attachment 556656 [details] [diff] [review]
bustage fix

Yeah well I could have spotted it or built locally before pushing too!

I don't know if you have a build environment set up already, but if you could build locally as a quick sanity check, it will make things quicker when I check patches in. Thanks :-)
Attachment #556656 - Flags: checkin?(bmo) → checkin+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.