Ctrl+T while in search mode should close search layer

VERIFIED FIXED in Firefox 9

Status

Firefox Graveyard
Panorama
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: ttaubert, Assigned: raymondlee)

Tracking

Trunk
Firefox 9

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

Pressing Ctrl+T to create new tab while in search mode, creates a new tab and zooms into it, but it doesn't close Panorama's search layer. When opening Panorama again after Ctrl+T the search layer is still visible.
Summary: Ctrl+T while in search should close search → Ctrl+T while in search mode should close search layer
(Assignee)

Updated

6 years ago
Assignee: nobody → raymond
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 555681 [details] [diff] [review]
v1
Attachment #555681 - Flags: review?(tim.taubert)
Comment on attachment 555681 [details] [diff] [review]
v1

Review of attachment 555681 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.
Attachment #555681 - Flags: review?(tim.taubert) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 555904 [details] [diff] [review]
Patch for checkin

Passed Try
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c80d69ea8f07
Attachment #555681 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/bace24f47138
Keywords: checkin-needed
Target Milestone: --- → Firefox 9
http://hg.mozilla.org/mozilla-central/rev/4362a0bf69e0
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:9.0a1) Gecko/20110907 Firefox/9.0a1
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:9.0a1) Gecko/20110907 Firefox/9.0a1
Mozilla/5.0 (X11; Linux x86_64; rv:9.0a1) Gecko/20110907 Firefox/9.0a1
Mozilla/5.0 (Windows NT 5.1; rv:9.0a1) Gecko/20110907 Firefox/9.0a1

Verified on Mac OS 10.7, Ubuntu 10.4, Windows XP, Windows 7 using the following steps:
1) Have multiple groups and tabs in Panorama.
2) Select the search button and type some characters.
3) Ctrl+T
4) Re-enter Panorama.
5) The search layer shouldn't be visible.

Also attempted to reproduce using multiple windows open, using switch-to-tab function before. Issue is no longer reproducible.
Verified fixed.
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.