681634 - Mozilla-central fails to build --with-static-checking

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Joshua Cranmer [:jcranmer]]

Notes:
1. Configure documentation suggests using gcc_dehydra.so, which causes things to fail immediately (Detect dehydra v. treehydra or hint to use treehydra).
2. Elfhack throws a JS Exception. --disable-elf-hack works.
3. The frame-verify script uses callable regex.
4. We have two failures for NS_OVERRIDE:
+ gfx/layers/ipc/ShadowLayersParent (RecvGetParentType)
+ content/svg/content/src/SVGMotionSMILAnimationFunction (TreatSingleValueAsStatic)
5. Linking errors in libxul.so:
../../js/jsd/jsd_atom.o: In function `MUST_FLOW_THROUGH':
/tmp/jcranmer-mozilla/obj-mc/js/jsd/../../dist/include/jsstaticcheck.h:48: multiple definition of `MUST_FLOW_THROUGH'
../../js/jsd/jsdebug.o:/tmp/jcranmer-mozilla/obj-mc/js/jsd/../../dist/include/jsstaticcheck.h:48: first defined here
[and more, similar]
6. Two files of the HTML parser (Element and Attribute names) cause out-of-memory errors.
7. I need a small patch to dehydra to add in a TYPE_PACK_EXPANSION to yet another switch statement (c_c).

Comment 1

[Joshua Cranmer [:jcranmer]]

The gfx/layers/ipc/ShadowLayersParent is a result of patch 3.1 on bug 648484, and appears to be a neglect to remove dead code.
The other NS_OVERRIDE I've traced is to bug 614879, and appears to be an actual problem (someone didn't change the later function).

Comment 2

[Joshua Cranmer [:jcranmer]]

Attachment: Fix use of regex in static analysis scripts

This changes the callable regex to execs.

Comment 3

[Joshua Cranmer [:jcranmer]]

Attachment: Fix bustage caused by cjones

This is the bustage due to NS_OVERRIDE in gfx.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 556651 [details] [diff] [review]
Fix bustage caused by cjones

Is this part of a grand scheme to get automated static checking builds again?  Oh please oh please oh please ...

Comment 5

[Joshua Cranmer [:jcranmer]]

These two patches have been pushed to mozilla-inbound.

Comment 6

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/23962193053c
http://hg.mozilla.org/mozilla-central/rev/2642c7b0dc60

Comment 7

[Joshua Cranmer [:jcranmer]]

[not quite fixed yet, see blocking bug and notes about the failure in htmlparser]

Comment 8

[Joshua Cranmer [:jcranmer]]

Dehydra support is deprecated.