568081 - Tracking bug: deploy static analysis builds on mozilla-central

Status: RESOLVED DUPLICATE of bug 851753

(Release Engineering :: General, defect, P3)

Description

[[e-mail]]

We want to have a Linux x86 static analysis build running on mozilla-central. This bug will track the buildbot integration and the various other technical bits (dehydra/gcc) that need to get solved.

The plan is:
1. Get things working using the refplatform in a VM
2. Give Lukas the steps, to hack into buildbot
3. Get them tested on staging
4. Profit!

Comment 1

[[e-mail]]

Refplatform is available at https://wiki.mozilla.org/ReferencePlatforms/Linux-Public.

Comment 2

[Benjamin Smedberg]

Ehren is on contract for this work.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Ah, ok - I was just putting to p5 my tracking of the work being done by Ehren. This is in the Release Engineering component after all.  However, when it's ready for staging Ehren can pass it back to me to integrate.

Comment 5

[Paul Biggar]

From bug 629264 comment 3, bsmedberg says:

> I was running it, and that machine died. Bug 568081 covers the
> release-engineering part of this. Ehren was supposed to be working on that as a
> contractor, but that has not happened and so it is currently unowned.

So how do we get this bug back on track?

Comment 6

[Benjamin Smedberg]

It currently is not being worked on, and I don't have anyone available to work on it. If you would like to take it, that would help get it back on track!

Comment 7

[Paul Biggar]

I don't have any idea how to go about this, but I think it's important, so I can put my time in on this.

Can you point me in the right direction?

Comment 8

[(dormant account)]

(In reply to comment #7)
> I don't have any idea how to go about this, but I think it's important, so I
> can put my time in on this.
> 
> Can you point me in the right direction?

1. Setup toolchain https://developer.mozilla.org/En/Dehydra/Installing_Dehydra
2. Do a build with --with-static-checking. 
3. Assuming above works, fix bug 559964 and ask build team to modify mozconfigs.

I gave up on step 3 due to weird failures+perf on try. Not sure how far Ehren got with 1&2.

Comment 9

[Benjamin Smedberg]

It's not enough to modify mozconfigs, you also need some steps to actually build treehydra on the build machine. But yeah, getting the static-checking build working again is the first step.

Comment 10

[[e-mail]]

You need to pull a specific rev of Spidermonkey, then build dehydra/treehydra. The last time I did this everything worked OK (afaict the static checking build at least ran). If you're interested I can pull the exact Spidermonkey rev that's known good.

Comment 11

[Joshua Cranmer [:jcranmer]]

I'll see if I can get this working while I keep waiting for dxr to index stuff. I'm currently downloading the reference VM.

Comment 12

[Joshua Cranmer [:jcranmer]]

Given that the reference VM only has gcc-4.1, I'm wondering if there are newer build platform images that I'm not finding...

Comment 13

[Joshua Cranmer [:jcranmer]]

I have a shell script which should be able to build mozilla-central with static-checking, but we have an issue in that changes to the JS engine cause the static analysis scripts to fail.

Comment 14

[Joshua Cranmer [:jcranmer]]

Attachment: How to do a static-checking build from scratch

Notes:
1. Set WORK= to be the temporary directory for building
2. CXX= needs to be exported to the necessary g++, and it needs plugin headers
3. configure will complain about an "error: PLUGIN_DECL not found"... this is not a fatal error, so should be ignored.
4. I get one error with treehydra in make check, but it otherwise seems to work.
5. mozilla-central doesn't actually build with static checking. Working on fixes.

Comment 15

[Joshua Cranmer [:jcranmer]]

With --disable-elf-hack, and a 2-liner to fix some static analysis script errors, this gets to somewhere in IPC before the pack expansion analysis causes the build to fail.

Comment 16

[Joshua Cranmer [:jcranmer]]

Dehydra is dead, let's use clang instead.