681666 - Add formnovalidate attribute to test_button_attribute_reflection.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 555426 [details] [diff] [review]
Patch v1

>--- a/content/html/content/test/forms/test_button_attributes_reflection.html
>+++ b/content/html/content/test/forms/test_button_attributes_reflection.html
>@@ -23,12 +23,19 @@ https://bugzilla.mozilla.org/show_bug.cg
> reflectLimitedEnumerated({
>   element: document.createElement("button"),
>   attribute: "type",
>   validValues: [ "submit", "reset", "button" ],
>   invalidValues: [ "this-is-probably-a-wrong-type", "", "tulip" ],
>   defaultValue: "submit",
> });
> 
>+// .formNoValidate
>+reflectBoolean({
>+  element: document.createElement("button"),
>+  attribute: "formNoValidate",
>+});
>+
>+

One empty line is enough. And I'd rather you didn't add the ',' at the end, but it looks like you got that past me before.

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to Ms2ger from comment #1)
> One empty line is enough.

Oups :)

> And I'd rather you didn't add the ',' at the end,
> but it looks like you got that past me before.

Sorry but I love that trailing comma and I'm pretty sure you don't want to break my hearth :)

Thanks for the quick review!

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/650aad33a441