Closed Bug 681666 Opened 8 years ago Closed 8 years ago

Add formnovalidate attribute to test_button_attribute_reflection.html

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #555426 - Flags: review?(Ms2ger)
Comment on attachment 555426 [details] [diff] [review]
Patch v1

>--- a/content/html/content/test/forms/test_button_attributes_reflection.html
>+++ b/content/html/content/test/forms/test_button_attributes_reflection.html
>@@ -23,12 +23,19 @@ https://bugzilla.mozilla.org/show_bug.cg
> reflectLimitedEnumerated({
>   element: document.createElement("button"),
>   attribute: "type",
>   validValues: [ "submit", "reset", "button" ],
>   invalidValues: [ "this-is-probably-a-wrong-type", "", "tulip" ],
>   defaultValue: "submit",
> });
> 
>+// .formNoValidate
>+reflectBoolean({
>+  element: document.createElement("button"),
>+  attribute: "formNoValidate",
>+});
>+
>+

One empty line is enough. And I'd rather you didn't add the ',' at the end, but it looks like you got that past me before.
Attachment #555426 - Flags: review?(Ms2ger) → review+
(In reply to Ms2ger from comment #1)
> One empty line is enough.

Oups :)

> And I'd rather you didn't add the ',' at the end,
> but it looks like you got that past me before.

Sorry but I love that trailing comma and I'm pretty sure you don't want to break my hearth :)

Thanks for the quick review!
Flags: in-testsuite+
Whiteboard: [needs review] → [inbound]
http://hg.mozilla.org/mozilla-central/rev/650aad33a441
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.