One issue is in bug 678161 comment 11: +ifeq ($(_MSC_VER),1500) +JSSHELL_BINS += $(DIST)/bin/msvcr100.dll +endif 1500 should be 1600. Another issue is that we don't remove the CRT dlls for MSVC versions we don't build against.
Attachment #555677 - Flags: review?(khuey) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Attachment #555677 - Attachment description: Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive → Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive [Checked in: Comment 3]
Assignee: nobody → mh+mozilla
Isn't @BINPATH@ unneeded/unwanted in removed-files.in?
Ah yes, that's true. Please file a followup bug.
(In reply to Mike Hommey [:glandium] from comment #5) > Ah yes, that's true. Please file a followup bug. I filed bug 696422.
You need to log in before you can comment on or make changes to this bug.