Fixups for MSVC > 8 after bug 678161

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
All
Windows 7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
One issue is in bug 678161 comment 11:

+ifeq ($(_MSC_VER),1500)
+JSSHELL_BINS += $(DIST)/bin/msvcr100.dll
+endif

1500 should be 1600.

Another issue is that we don't remove the CRT dlls for MSVC versions we don't build against.
(Assignee)

Comment 1

6 years ago
Created attachment 555677 [details] [diff] [review]
Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive
[Checked in: Comment 3]
Attachment #555677 - Flags: review?(khuey)
Attachment #555677 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/projects/build-system/rev/c37f23b36e54
Whiteboard: fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/c37f23b36e54
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Attachment #555677 - Attachment description: Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive → Add the CRT dlls we don't use to the remove-files lists. Also fix inclusion of the MSVC 10 CRT in the js shell archive [Checked in: Comment 3]
Assignee: nobody → mh+mozilla
Flags: in-testsuite-
Isn't @BINPATH@ unneeded/unwanted in removed-files.in?
(Assignee)

Comment 5

6 years ago
Ah yes, that's true. Please file a followup bug.
Blocks: 694371
Depends on: 696422
(In reply to Mike Hommey [:glandium] from comment #5)
> Ah yes, that's true. Please file a followup bug.

I filed bug 696422.
You need to log in before you can comment on or make changes to this bug.