682017 - Remove CustomKeySender and use content KeyEvents forwarding

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oleg Romashin (:romaxa)]

I think it is time to remove CustomKeySender from fennec and switch to dom/IPC content key events forwarding

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Kill CustomKeySender

Comment 2

[Oleg Romashin (:romaxa)]

Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

Don't have android with keyboard, can someone try this:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c08f956fcab1
http://stage.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-c08f956fcab1/try-android/
?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

Looks ok. Oleg, can you briefly talk about why this is not needed anymore? Where is the magic happening now? Can we cleanup any code in the content.js file too?

Comment 4

[Oleg Romashin (:romaxa)]

Magic happening here:
https://bugzilla.mozilla.org/show_bug.cgi?id=583976
Not sure about content part, probably I need to take my N950 with HW keyboard and check it .

Comment 5

[Oleg Romashin (:romaxa)]

Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

No we should not remove content keys stuff... otherwise key events short cuts will not work.
With attached patch it works fine, shortcuts and general text input.
Tested on N900 (don't have android with keyboard)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

OK, let's give this a try

Comment 7

[Ed Morley [:emorley]]

In my queue with a few other bits that are being sent to try first and then onto inbound.

Comment 8

[Oleg Romashin (:romaxa)]

It actually has been on try already: see 682017#c2

Comment 9

[Ed Morley [:emorley]]

Sorry missed that, however the other items needed to go through try anyway and batching a few checkin-neededs at once when pushing to inbound saves a bunch of build pool time.

Comment 10

[Ed Morley [:emorley]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/bc4b2d84f80a

Comment 11

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/bc4b2d84f80a

Comment 12

[Doug Turner (:dougt)]

backed out.  caused 684558.

Comment 13

[Matt Brubeck (:mbrubeck)]

Try run is green: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=cdb8f52e8801

Pushed to inbound along with regression fixes (bug 683736 and bug 684558):
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0991759b732

Comment 14

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/f0991759b732