Closed Bug 682017 Opened 8 years ago Closed 8 years ago

Remove CustomKeySender and use content KeyEvents forwarding

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: romaxa, Assigned: romaxa)

References

Details

Attachments

(1 file)

I think it is time to remove CustomKeySender from fennec and switch to dom/IPC content key events forwarding
Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

Looks ok. Oleg, can you briefly talk about why this is not needed anymore? Where is the magic happening now? Can we cleanup any code in the content.js file too?
Attachment #555777 - Flags: feedback?(mark.finkle) → feedback+
Magic happening here:
https://bugzilla.mozilla.org/show_bug.cgi?id=583976
Not sure about content part, probably I need to take my N950 with HW keyboard and check it .
Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

No we should not remove content keys stuff... otherwise key events short cuts will not work.
With attached patch it works fine, shortcuts and general text input.
Tested on N900 (don't have android with keyboard)
Attachment #555777 - Flags: review?(mark.finkle)
Comment on attachment 555777 [details] [diff] [review]
Kill CustomKeySender

OK, let's give this a try
Attachment #555777 - Flags: review?(mark.finkle) → review+
Keywords: checkin-needed
In my queue with a few other bits that are being sent to try first and then onto inbound.
Assignee: nobody → romaxa
Status: NEW → ASSIGNED
Keywords: checkin-needed
It actually has been on try already: see 682017#c2
Sorry missed that, however the other items needed to go through try anyway and batching a few checkin-neededs at once when pushing to inbound saves a bunch of build pool time.
http://hg.mozilla.org/mozilla-central/rev/bc4b2d84f80a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 683736
Depends on: 684558
backed out.  caused 684558.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Try run is green: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=cdb8f52e8801

Pushed to inbound along with regression fixes (bug 683736 and bug 684558):
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0991759b732
Status: REOPENED → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Target Milestone: Firefox 9 → Firefox 10
https://hg.mozilla.org/mozilla-central/rev/f0991759b732
Status: ASSIGNED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Depends on: 691418
Depends on: 692123
You need to log in before you can comment on or make changes to this bug.