Last Comment Bug 691418 - Back/escape key goes back twice in local tabs
: Back/escape key goes back twice in local tabs
Status: VERIFIED FIXED
[pushed]
: regression
Product: Fennec Graveyard
Classification: Graveyard
Component: General (show other bugs)
: Firefox 10
: All All
: -- normal (vote)
: Firefox 10
Assigned To: Matt Brubeck (:mbrubeck)
:
Mentors:
Depends on: 684558
Blocks: 682017 683736
  Show dependency treegraph
 
Reported: 2011-10-03 11:06 PDT by Matt Brubeck (:mbrubeck)
Modified: 2011-10-04 06:12 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (843 bytes, patch)
2011-10-03 11:06 PDT, Matt Brubeck (:mbrubeck)
mark.finkle: review+
romaxa: feedback+
Details | Diff | Review

Description Matt Brubeck (:mbrubeck) 2011-10-03 11:06:15 PDT
Created attachment 564260 [details] [diff] [review]
patch

Steps to reproduce:
1. Open an about: page in Fennec (about:home)
2. In the same tab, navigate to a different about: page (like about:about)
3. In the same tab, navigate to a third about: page (like about:support)
4. Press the hardware "Back" button (Android) or escape key (desktop)

Expected results: Fennec navigates back to the page from step 2.
Actual results: Fennec navigates back to the page from step 1.

This is just like bug 684558, but for local browsers.  As far as I can tell, key forwarding and re-dispatching works the same for local browsers as for remote ones, so this "remote=true" check should not be here.
Comment 1 Oleg Romashin (:romaxa) 2011-10-03 11:09:35 PDT
Comment on attachment 564260 [details] [diff] [review]
patch

Yep, I had some doubts about that check, but did not go to deeply in order to figure out why that specific hack was performed
Comment 2 Matt Brubeck (:mbrubeck) 2011-10-03 12:58:25 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/c8fbb8a9b5a5
Comment 3 Matt Brubeck (:mbrubeck) 2011-10-03 16:50:01 PDT
https://hg.mozilla.org/mozilla-central/rev/c8fbb8a9b5a5
Comment 4 Aaron Train [:aaronmt] 2011-10-04 06:12:04 PDT
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1

Note You need to log in before you can comment on or make changes to this bug.