691418 - Back/escape key goes back twice in local tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Open an about: page in Fennec (about:home)
2. In the same tab, navigate to a different about: page (like about:about)
3. In the same tab, navigate to a third about: page (like about:support)
4. Press the hardware "Back" button (Android) or escape key (desktop)

Expected results: Fennec navigates back to the page from step 2.
Actual results: Fennec navigates back to the page from step 1.

This is just like bug 684558, but for local browsers.  As far as I can tell, key forwarding and re-dispatching works the same for local browsers as for remote ones, so this "remote=true" check should not be here.

Comment 1

[Oleg Romashin (:romaxa)]

Comment on attachment 564260 [details] [diff] [review]
patch

Yep, I had some doubts about that check, but did not go to deeply in order to figure out why that specific hack was performed

Comment 2

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c8fbb8a9b5a5

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/c8fbb8a9b5a5

Comment 4

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111004 Firefox/10.0a1 Fennec/10.0a1