682117 - Atom Feed Author Name Chokes on "Greater Than" or "Less Than" Characters

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[j3vasko]

Attachment: Without the Email Field Specified on the Atom Feed

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.5; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build ID: 20110413222027

Steps to reproduce:

Added an atom feed that has:
<entry><author><name>

With:
<![CDATA[<(root)>]]>

Make sure the feed does NOT use the tag:
<email>


Actual results:

Thunderbird butchers the name in the [From] name column and displays just:
<

Thunderbird also butchers the [From] name when viewing the individual feed entry as:
< <root>>


Expected results:

Thunderbird should display the name correctly in the [From] name column as:
<(root)>

Thunderbird should also display the name correctly when viewing the individual feed entry as:
<(root)>

Comment 1

[j3vasko]

The WORKAROUND for this is to have the atom feed publisher add the email field as follows:
<email>@</email>

The email field is NOT completely filled out because there is no email that applies here.

With this WORKAROUND 1 bad side effect is that when viewing the individual message entry you will see the following in the [From] field:
<(root)> <@>

See attachment:
WORKAROUND: Email Field Specified as @ on the Atom Feed

Also, please note that Thunderbird will allow you to add a contact to your address book with display name:
<(root)>

So it should allow this same author name on a feed.

Comment 2

[j3vasko]

Attachment: WORKAROUND: Email Field Specified as @ on the Atom Feed

Comment 4

[j3vasko]

Both screen shots are from the same feed but the code in the feed was updated between screen shots.

This is also an issue if you subscribe to:
http://en.wikipedia.org/w/index.php?title=Special:RecentChanges&feed=atom

Notice all the values in the [From] Column in Thunderbird are surrounded by < and > after subscribing.

Comment 5

[alta88]

Attachment: feedAuthor.patch

adding <> to email less names is not what imap/pop/nntp does to display From in the threadpane list, it doesn't 'look nicer', and it causes bugs like this.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 808204 [details] [diff] [review]
feedAuthor.patch

Review of attachment 808204 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/c769d20360ff