1522156 - When a search results messages from an RSS feed, wrong random authors are shown

Status: RESOLVED FIXED

(MailNews Core :: Search, defect)

Description

[meisterasrael]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

I have severel RSS feeds in my Thunderbird Feeds. When use the search function to search for words appearing in articles I got via an RSS feed, the author seems to be a randomly chosen one.

Actual results:

At the position where the author is shown for emails, RSS entries show a random author, either from an email I got or from another feed.

Expected results:

Some name related to the feed, for example the feeds website.

Comment 1

[Jorg K (CEST = GMT+2)]

Which search function? "Search Messages"/Quick Filter or Global search?

"Search Messages" shows the "From" (author) as the feed name as shown in the feed messages. Looks like Gloda works the same. Can you attach a screenshot?

Comment 2

[meisterasrael]

Attachment: screenshot.png

I used the search field in the upper right corner.

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks, that Ctrl+K field is the global search, also called Gloda. I tried it myself and the From is the From from a different feed :-( - So confirming the bug.

Magnus, in your planning, have you included giving Gloda some TLC?

Comment 4

[alta88]

I've noticed search issues (with quick filter) on feed From in the past, and have a suspicion that Bug 682117 may be involved. I'd test to see if so but local builds are broken atm.

The problem is that a feed Author is rarely an RFC5322 compliant email, yet search and mime parsing, and probably gloda, are geared to such a structure. However, RFC6854 udpates that, for From, by recognizing it is used for display purposes, and non email feed Authors should be stored using a group syntax. Yet jsmime, despite being a condition of landing, did not implement this generically, and who knows how libmime or search handle groups syntax parsing in the From field. (I've mentioned this all before).

Comment 5

[Magnus Melin [:mkmelin]]

Noted. I don't think it ranks very high on the priority list unfortunately.

Comment 6

[alta88]

This is indeed a regression from Bug 682117, due to gloda not handling a From field that is not an email and is not angle bracket enclosed.

Comment 7

[alta88]

This is strictly fixed in Bug 1423487, and feeds with single authors should work fine now (other than displaying non ascii - Bug 1528496). Multiple authors don't work yet in gloda search and that depends on Bug 1526985.