Closed Bug 682176 Opened 8 years ago Closed 8 years ago

Port Bug 652657 - Provide opt-in UI for Telemetry

Categories

(Thunderbird :: Testing Infrastructure, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: protz, Assigned: protz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

The number of users who enabled Telemetry is desperately low. I think we should provide opt-in UI for that starting with Thunderbird 9.
Yay! One more patch for you, bwinton :-). Hopefully this should give us more users reporting telemetry data, because the number is quite low right now. I'm wondering if we could also enable this on aurora... (although there's new strings in the patch and I don't know if new strings are accepted on aurora).
Attachment #555933 - Flags: review?(bwinton)
Some comments:

- I think we need to block this on a privacy review that's specific for Thunderbird. I suspect there is no issue here, however, we should at least ensure we get text in our new privacy policy that's appropriate for us.
- Hence, we're going to need to override toolkit.telemetry.infoURL with a url for our own policy (why a generic pref for an app-specific thing I have no idea).
- Re strings: you should read the "What happens where" section of http://people.mozilla.org/~mbanner2/tbdevspecifics/
(In reply to Jonathan Protzenko [:protz] from comment #0)
> The number of users who enabled Telemetry is desperately low. I think we
> should provide opt-in UI for that starting with Thunderbird 9.

Well announcing things in the middle of the summer doesn't help. How bad are the numbers ?
Well it's getting better: we had three submissions yesterday...

Is the Thunderbird privacy policy up already or not?
Also, who should I ask for a privacy review that concerns Thunderbird?
(In reply to Mark Banner (:standard8) from comment #2)
> Some comments:
> 
> - I think we need to block this on a privacy review that's specific for
> Thunderbird. 
Adding the right dependency; I've asked Sid Stamm for the privacy review on the other bug (more backend-oriented). Talked with David Bienvenu about updating the Thunderbird privacy policy to include the "usage statistics" bit from Firefox.
Depends on: 681873
Comment on attachment 555933 [details] [diff] [review]
Add an opt-in telemetry support for Thunderbird

Review of attachment 555933 [details] [diff] [review]:
-----------------------------------------------------------------

So yeah, my biggest complaint with this is summed up in the following screenshot:
http://dl.dropbox.com/u/2301433/TestPilot/PrivacyPolicy.png  :)

The code is mostly good, modulo my comments below, but I'ld like to see the new privacy policy link, so I'm going to say r- for now.

Thanks,
Blake.

::: mail/base/content/specialTabs.js
@@ -247,1 +248,5 @@
> >  
> > +const kTelemetryPrompted    = "toolkit.telemetry.prompted";
> > +const kTelemetryEnabled     = "toolkit.telemetry.enabled";
> > +const kTelemetryServerOwner = "toolkit.telemetry.server_owner";
> > +const kTelemetryInfoUrl     = "toolkit.telemetry.infoURL";

So, for my complaint above, did we want to override toolkit.telemetry.infoURL, or create mail.telemetry.infoURL, or ask Firefox to move their pref somewhere else?

::: mail/components/preferences/advanced.xul
@@ -191,4 +194,5 @@
> >            <groupbox>
> >              <caption label="&configEditDesc.label;"/>
> >              <vbox>
> >                <hbox>
> > +                <checkbox id="submitTelemetry"

It would be nice to have the link to the infoURL here, too, in case people (like me) forget what it was they signed up for.

::: mail/themes/pinstripe/mail/mailWindow1.css
@@ -503,3 +503,5 @@
> >  .tabmail-tab[type="message"] {
> >    list-style-image: url("chrome://messenger/skin/icons/message-mail.png");
> >  }
> > +
> > +.telemetry-text-link {

We only need this rule for Mac?
Attachment #555933 - Flags: review?(bwinton) → review-
Blake, I'm asking re-review from you since you r-'d the previous iteration. I've fixed all your remarks. As to the white text link, yes, we need it on Mac only, I'm about to attach a screenshot.

Mark, I'm asking feedback from you, so that you can tell us whether we're able to land this without the privacy policy being up, or if we need to wait for the privacy policy to be online before landing this (I guess the latter, but... who knows? :-)).
Attachment #555933 - Attachment is obsolete: true
Attachment #556726 - Flags: review?(bwinton)
Attachment #556726 - Flags: feedback?(mbanner)
Other platform have a light grey background, so the default color for the .text-link (blue) works fine.
Comment on attachment 556726 [details] [diff] [review]
Update patch with review comments addressed

Review of attachment 556726 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to say r-, because of the new 3-pane window opening, but I think we're fairly close, and we'll get there by the time the Privacy document goes live.

Thanks,
Blake.

::: mail/app/profile/all-thunderbird.js
@@ +323,5 @@
>  pref("browser.display.auto_quality_min_font_size", 0);
>  
>  pref("view_source.syntax_highlight", false);
> +
> +pref("toolkit.telemetry.infoURL", "http://www.mozilla.org/legal/privacy/thunderbird.html");

I suspect we want a "#telemetry" on the end of this url.  And I'm checking with Alex Fowler to see whether this is actually the correct url for this document.

::: mail/components/preferences/advanced.xul
@@ -200,0 +204,10 @@
> > +              <hbox>
> > +                <checkbox id="submitTelemetry"
> > +                          preference="toolkit.telemetry.enabled"
> > +                          label="&submitTelemetry.label;"
NaN more ...

Hmm, that opened a new window for me, instead of a tab in the existing 3-pane.  I would rather open the link in a browser in this case, if we can't open the content tab in the background.

Or perhaps closing the dialog and then opening the tab would be reasonable.

(Fortunately, I don't want to land this patch until the privacy policy goes up, so you've got some time to fix it.  ;)
Attachment #556726 - Flags: review?(bwinton) → review-
And I've heard back that the url to use is "http://www.mozilla.org/en-US/legal/privacy/thunderbird.html#telemetry".  It's not up yet, but will be hopefully soon.

Thanks,
Blake.
I wonder if it's a good thing to set toolkit.telemetry.prompted to true even if the user doesn't click on "No".

They did it for Firefox, and only 4% of the nightly and aurora builds users did opt in (see bug 679431 comment 4).

Of course, since Thunderbird is less tab and window intensive maybe there's more chance the user will notice the bar before it closes itself.

But in case not enough users opt in, you may want to at least set a different pref when the user clicks on "No".
E.g. toolkit.telemetry.refused set to true only when the user clicks on "No".
Then if there isn't enough opt-ins, you could later use a notification that sticks until the user clicks on "Yes" or "No". And the users who already clicked on "No" won't be annoyed again.
After discussion with Sid Stamm, the text that we're displaying in the notification bar doesn't accurately reflect all the measurements that have been added since (see for an example https://wiki.mozilla.org/Privacy/Reviews/Telemetry/Measurements). We might want to consider updating that text.

The UI might change in the near future on the Firefox side too (bug 683340) so we should watch this closely. By the time the privacy policy is up, Firefox might have changed their UI already... :(
The policy is near landing, such that I think we can go with the final landing of this. The URL should be:

http://www.mozilla.org/en-US/thunderbird/legal/privacy/#telemetry

assume that for now, but let me do final confirmation before landing (should be later today).
Attached patch Final patchSplinter Review
This should only require make chrome. The privacy policy now always opens in a mail:3pane. The URL will be fixed before commit.
Attachment #556726 - Attachment is obsolete: true
Attachment #556726 - Flags: feedback?(mbanner)
Attachment #562506 - Flags: review?(bwinton)
Comment on attachment 562506 [details] [diff] [review]
Final patch

Review of attachment 562506 [details] [diff] [review]:
-----------------------------------------------------------------

All in all, I like it.  r=me with the nits below fixed.

Thanks,
Blake.

::: mail/app/profile/all-thunderbird.js
@@ +323,5 @@
>  pref("browser.display.auto_quality_min_font_size", 0);
>  
>  pref("view_source.syntax_highlight", false);
> +
> +pref("toolkit.telemetry.infoURL", "http://www.mozilla.org/legal/privacy/thunderbird.html#telemetry");

The url posted in the bug was "http://www.mozilla.org/en-US/thunderbird/legal/privacy/#telemetry".  Are you sure this is right?

::: mail/base/content/utilityOverlay.js
@@ -292,0 +290,9 @@
> > +
> > +/**
> > + * Open the privacy policy in a new content tab, if possible in an available
> > + * mail:3pane window, otherwise by opening a new mail:3pane.
NaN more ...

It would be cool if this re-focused the currently-open content tab, but that could wait for a follow-up bug.  (Also, the comment above about opening up a new mail:3pane seems wrong.)
Attachment #562506 - Flags: review?(bwinton) → review+
http://hg.mozilla.org/comm-central/rev/5a4025abde43
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Blocks: 689262
You need to log in before you can comment on or make changes to this bug.