Closed Bug 68247 Opened 25 years ago Closed 25 years ago

Search: Open (and future File, Delete) button should be moved to right of results.

Categories

(SeaMonkey :: MailNews: Message Display, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
mozilla0.9

People

(Reporter: laurel, Assigned: andreww)

References

()

Details

Attachments

(5 files)

Using feb8 commercial trunk builds Open button is implemented, but is in a bad location within the search messages dialog. The Open, File and Delete buttons should be placed to the right side of the results pane per spec (don't see the search spec yet posted on mozilla.org), but available internally to netscape. The Open button is currently positioned along the bottom of the dialog adjacent to the Close (close dialog) button. This positioning is confusing.
Keywords: nsbeta1
QA Contact: esther → laurel
Would it be sufficient to align the buttons (except for Close) along the left of the bottom of the window? I'm worried that putting buttons to the right might make the tree too narrow to see the subject/sender/date easily.
marking nsbeta1-
Keywords: nsbeta1 → nsbeta1-
Target Milestone: --- → Future
Open button really shouldn't be grouped with the window control button (Close) at the bottom.
OK, now that the Delete and File buttons have been added in the wrong location also, this dialog looks really bad. Buttons used to perform functionality on the window, Delete and Open, should not be group with the "Close" button. The File button is the wrong widget type and is located off to the bottom left of the dialog on its own. This is just sloppy. Removing minus so this bug is reconsidered.
Keywords: nsbeta1- → nsbeta1, nsCatFood
*** Bug 73411 has been marked as a duplicate of this bug. ***
I just marked 73411 as a dup. Not only is file in the wrong place, but it also needs to use the correct widget. marking nsbeta1+
Keywords: nsCatFood → nsCatFood+
Whiteboard: [nsbeta1+]
Target Milestone: Future → mozilla0.9
reassigning bug to me - hope that's ok - talked to putterman about it.
Assignee: gayatrib → andreww
xul is ready - but I need to add a new css class to make the menubutton look right.
Status: NEW → ASSIGNED
Themes Triage Team Marking nsbeta1+ (was + in status from mailnews)
Keywords: nsbeta1 → nsbeta1+
Priority: -- → P2
Whiteboard: [nsbeta1+]
Also, now, pressing enter after selecting some search results deletes the selected messages, which is surprising ...I would rather see them opened instead.
In answer to the last comment (by Tuukka), the Enter==delete problem is covered under bug 74407.
patch submitted, ready for review.
Keywords: review
patch looks good, some tabbing space issues though + <box orient="vertical"> + <spring flex="1" /> for example. Other than that, r=doronr@naboonline.com
created new patch with fixes for delete button - it wasnt using a DTD . The File button isnt moved yet because the default look for that button has not yet been created, so it might not look right there between the other two buttons. There (is/will be) another bug filed on there not being a default look for menubuttons.
btw, there are still some tabbing issues in that patch.
righto - Ill fix the tab issues before checking it in.
sr courtesy of sspitzer
fix checked into tree
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Using apr12 commercial trunk build with win98, linux rh6.2, mac OS 9.0: OK for Open and Delete buttons -- they've been moved to side of results list box. What about the File button -- who's going to move it and should we reuse this bug for it or log another?
Andrew is working on getting the correct widget for the file button. I think it would be best to file another bug and assign it to him.
bug 62722 covers the editable menulists not being implemented. I would say file a new bug on the file button after that comes in. So file a new bug on file not being in the right place, send it to me, and Ill set 62722 as depends, then fix that bug after 62722 gets fixed.
Marking verified. New report is bug 75812.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
Component: MailNews: Search → MailNews: Message Display
QA Contact: laurel → search
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: