75812 - Search Messages UI: File/Move button needs to be moved.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[laurel]

Using apr12 commercial trunk build, all platforms

Leftover issue from bug 68247...

The File/Move button in the search mail/news messages ui needs to be moved to
the right of the dialog per ui spec at
http://www.mozilla.org/mailnews/specs/search/ .

Dependent on fix for bug 62722

Comment 1

[andreww]

Yep - Ill move it over as soon as the file button get's some xbl loving from hewitt.

Comment 2

[hangas]

Marking nsbeta1+ and 0.9.1

Comment 3

[andreww]

still waiting on 62722 ...

Comment 4

[andreww]

Now that hewitt has checked in new modern, I can transfer his menubutton xbl
over to classic, and then move this button over.

Comment 5

[laurel]

Need clarification:  since File in Search Messages UI doesn't look like a
button/dropdown in classic skin, may08 trunk build, will this take care of the
appearance in classic from text to button? Or do I need to log a separate bug?

Comment 6

[andreww]

Ill fix classic skin as well to make it work properly.  No need for another bug.

Comment 7

[andreww]

Added new depends.  Menulistbuttons dont work right now (default ones).  And I 
need that to port over to classic skin.

Comment 8

[andreww]

Attachment: patch to move the file button. needed some tweaking in modern due to some margins being too large.

Comment 9

[andreww]

patch ready for review.

Comment 10

[andreww]

sr=hewitt (verbally, now I'm just adding it)

Comment 11

[andreww]

seeking reviewer

Comment 12

[timeless]

    <box align="left">
    </box>
^is this useful/required?

-       <box orient="vertical">
+       <box orient="vertical" >
^this change shouldn't be made.

r=timeless.

warning: patch had \r line endings and is one rev out of date :(

Comment 13

[andreww]

ok Ill remove that - it's not serving any further purpose.

Comment 14

[andreww]

fix checked into tree.

Comment 15

[laurel]

Well, the button is moved, but it has a couple problems in may14 commercial 
build, all platforms:
1.  Size is not consistent with the other buttons
2.  Classic skin still has text only, no button... you said this was going to be 
done inclusive in this bug. If we need a new one opened I'll do so.

Reopening ... 

Comment 16

[andreww]

laurel,the bug 78686 seems to cover those issues.  I had been waiting to fix this 
based on the dependancy about that button not working properly but had decided to 
move it anyway so that all that needs to happen now is to get the button looking/
working properly through 78686.  Perhaps you could add comments to that bug about 
making sure it works on classic as well as modern, and size properly...

Comment 17

[laurel]

andreww:  Bug 78686 is to address that the File button broke completely upon the 
landing of the new modern sking.  The file button does indeed work in the 
classic skin, it just doesn't look right -- that's why I asked you on may08.

 As for the size, I don't think that's necessarily addressed in 78686, but will 
check it when that's fixed.

I guess you're done here in this bug? I'll file a separate classic skin bug?

Comment 18

[andreww]

ok I see. Yes please file a separate bug on the classic part not working. Ill 
make sure when I check that in to get the button to flex properly sizewise and 
Ill talk to hewitt about that issue in modern. 

Comment 19

[andreww]

remarking fixed given new bugs filed.  At least the button's moved now :)

Comment 20

[laurel]

Button is moved.
Marking this verified.
May 17 commercial trunk builds.