682790 - ignore implicit label association when it's associated explicitly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

If @for attribute (explicit label association) is used then don't create relations for label content (implicit association).

See http://www.w3.org/TR/html4/interact/forms.html#h-17.9.1

"for = idref [CS]
    This attribute explicitly associates the label being defined with another control. When present, the value of this attribute must be the same as the value of the id attribute of some other control in the same document. When absent, the label being defined is associated with the element's contents. "

Example,
<label for="btn"><input type="button" id="btn" value="button"></label>
This results in duped name and accessible relations.

Comment 1

[alexander :surkov (:asurkov)]

the fix should be resided in AccIterator.cpp HTMLLabelIterator::Next(), we shouldn't pick up implicit association if @for attribute is presented on label. 

mochitest: name/test_general.html and relations/test_general.html under label section, couple examples is enough:
<label for="btn"><input type="button" id="btn" value="button"></label>
<label for="btn"><input type="button" value="button2"></label>

Comment 2

[James Teh [:Jamie]]

Is this a dup of bug 669312?

Comment 4

[alexander :surkov (:asurkov)]

(In reply to James Teh [:Jamie] from comment #2)
> Is this a dup of bug 669312?

right, thank you, Jamie.

Comment 5

[alexander :surkov (:asurkov)]

this bug can be seen
1) http://www.html5accessibility.com/tests/form-labels.html (example from bug 669312)
2) facebook.com (log in button)

Comment 6

[steve faulkner]

(In reply to alexander surkov from comment #0)
> If @for attribute (explicit label association) is used then don't create
> relations for label content (implicit association).
> 
> See http://www.w3.org/TR/html4/interact/forms.html#h-17.9.1
> 
> "for = idref [CS]
>     This attribute explicitly associates the label being defined with
> another control. When present, the value of this attribute must be the same
> as the value of the id attribute of some other control in the same document.
> When absent, the label being defined is associated with the element's
> contents. "
> 
> Example,
> <label for="btn"><input type="button" id="btn" value="button"></label>
> This results in duped name and accessible relations.

Marco asked me in the dupe of this bug whether I have seen this pattern used in the wild (https://bugzilla.mozilla.org/show_bug.cgi?id=669312#c1) I have recently noticed it on Google sites:(https://sites.google.com/)
example:

<label for="search-site"><input type="checkbox" onclick="JOT_postEvent('onSearchConfigChange');" id="search-site" jotid="search-site"> this site</label>

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 8

[Marco Zehe (:MarcoZ)]

Comment on attachment 560878 [details] [diff] [review]
patch

r=me, thanks!

Comment 9

[alexander :surkov (:asurkov)]

inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/7134aa74087d

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/7134aa74087d

Comment 11

[Akkash Transport Company in Jeddah]

https://almostafaclean.com/furniture-transfer-company-jeddah/