can't set address book in filters

RESOLVED FIXED in Thunderbird 9.0

Status

defect
--
major
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: wsmwk, Assigned: mconley)

Tracking

({regression})

Trunk
Thunderbird 9.0
x86_64
Windows 7
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird7+ fixed, thunderbird8+ fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

8 years ago
another AB regression. I used trunk. Didn't test v6

1. Filters | New
2. pick From
3. pick "is in my address book"

No ABs listed

error console ...
Warning: XUL box for stringbundleset element contained an inline stringbundle child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/FilterEditor.xul
Line: 0
This is a regression affecting TB 7.0+, caused by bug 652855.

I'll take it.
Assignee: nobody → mconley
Posted patch Patch v1 (obsolete) — Splinter Review
First pass at a patch.  Try builds available here:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=b2872daffa2b
Reporter

Updated

8 years ago
Duplicate of this bug: 682548
Comment on attachment 556600 [details] [diff] [review]
Patch v1

>+        <xul:menupopup class="search-value-popup">

I think using "class="addrbooksPopup" and a few attributes would mean you can just reuse the existing code ;-)
Reporter

Comment 5

8 years ago
http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/mconley@mozilla.com-b2872daffa2b/try-win32/ WFM on two systems - laptop, and the system on which I reported the bug.

nothing in error console other than 
Warning: XUL box for stringbundleset element contained an inline stringbundle child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/FilterEditor.xul
Line: 0
Posted patch Patch v2 (obsolete) — Splinter Review
Thanks for the tip, Standard8 - done.  Tests were failing on OSX - fixed, hopefully.

Try results arriving here:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=e92d9805fa84
Attachment #556600 - Attachment is obsolete: true
Comment on attachment 556873 [details] [diff] [review]
Patch v2

Try builds look OK.
Attachment #556873 - Flags: review?(mbanner)
Attachment #556873 - Flags: approval-comm-beta?
Attachment #556873 - Flags: approval-comm-aurora?
Comment on attachment 556873 [details] [diff] [review]
Patch v2

+        <xul:menupopup class="addrbooksPopup">
         </xul:menupopup>

nit: we can make this just:

<xul:menupopup class="addrbooksPopup"/>
Attachment #556873 - Flags: review?(mbanner)
Attachment #556873 - Flags: review+
Attachment #556873 - Flags: approval-comm-beta?
Attachment #556873 - Flags: approval-comm-beta+
Attachment #556873 - Flags: approval-comm-aurora?
Attachment #556873 - Flags: approval-comm-aurora+
Standard8 spotted this - we only want to display local address books.  Modified the test case to check for this.
Attachment #556873 - Attachment is obsolete: true
Attachment #557278 - Flags: review?(mbanner)
Attachment #557278 - Flags: approval-comm-beta?
Attachment #557278 - Flags: approval-comm-aurora?
Attachment #557278 - Flags: review?(mbanner)
Attachment #557278 - Flags: review+
Attachment #557278 - Flags: approval-comm-beta?
Attachment #557278 - Flags: approval-comm-beta+
Attachment #557278 - Flags: approval-comm-aurora?
Attachment #557278 - Flags: approval-comm-aurora+
Assignee

Updated

8 years ago
Keywords: checkin-needed
Checked in:

http://hg.mozilla.org/comm-central/rev/c289427bf241
http://hg.mozilla.org/releases/comm-aurora/rev/121d0daa0447
http://hg.mozilla.org/releases/comm-beta/rev/b1112e39c4b1
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
You need to log in before you can comment on or make changes to this bug.