682803 - can't set address book in filters

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[Wayne Mery (:wsmwk)]

another AB regression. I used trunk. Didn't test v6

1. Filters | New
2. pick From
3. pick "is in my address book"

No ABs listed

error console ...
Warning: XUL box for stringbundleset element contained an inline stringbundle child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/FilterEditor.xul
Line: 0

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is a regression affecting TB 7.0+, caused by bug 652855.

I'll take it.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

First pass at a patch.  Try builds available here:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=b2872daffa2b

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 556600 [details] [diff] [review]
Patch v1

>+        <xul:menupopup class="search-value-popup">

I think using "class="addrbooksPopup" and a few attributes would mean you can just reuse the existing code ;-)

Comment 5

[Wayne Mery (:wsmwk)]

http://ftp.mozilla.org/pub/mozilla.org/thunderbird/try-builds/[e-mail]-b2872daffa2b/try-win32/ WFM on two systems - laptop, and the system on which I reported the bug.

nothing in error console other than 
Warning: XUL box for stringbundleset element contained an inline stringbundle child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/FilterEditor.xul
Line: 0

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2

Thanks for the tip, Standard8 - done.  Tests were failing on OSX - fixed, hopefully.

Try results arriving here:  http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=e92d9805fa84

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 556873 [details] [diff] [review]
Patch v2

Try builds look OK.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 556873 [details] [diff] [review]
Patch v2

+        <xul:menupopup class="addrbooksPopup">
         </xul:menupopup>

nit: we can make this just:

<xul:menupopup class="addrbooksPopup"/>

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v3 - now with localonly goodness

Standard8 spotted this - we only want to display local address books.  Modified the test case to check for this.

Comment 10

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/comm-central/rev/c289427bf241
http://hg.mozilla.org/releases/comm-aurora/rev/121d0daa0447
http://hg.mozilla.org/releases/comm-beta/rev/b1112e39c4b1