Closed Bug 682808 Opened 9 years ago Closed 9 years ago

Improve the way nsIClassInfo is handled in components (Port bug 658632 to SeaMonkey)

Categories

(SeaMonkey :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.6

People

(Reporter: neil, Assigned: Callek)

References

()

Details

Attachments

(1 file)

Bug 658632 improves the way nsIClassInfo is handled in components.
Bug 682587 fixed one of the cases in smileApplication.js but there are at least four cases still to fix in suite.
Summary: Port bug 658632 to SeaMonkey → Improve the way nsIClassInfo is handled in components (Port bug 658632 to SeaMonkey)
Assignee: nobody → bugspam.Callek
Attached patch v1Splinter Review
This should do it for us.
Attachment #560762 - Flags: review?(neil)
Attachment #560762 - Attachment is patch: true
Comment on attachment 560762 [details] [diff] [review]
v1

>+nsSidebar.prototype.classInfo = XPCOMUtils.generateCI(
>+        {classID: SIDEBAR_CID,
[I have a very slight preference for the { on the end of the previous line. Also, that's an unusually large amount of indentation, 4 spaces should be enough.]
Attachment #560762 - Flags: review?(neil) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: helpwanted
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
Comment on attachment 560762 [details] [diff] [review]
v1

http://hg.mozilla.org/comm-central/rev/9da1e377dc9d

Requesting Approval for comm-aurora[8]
Attachment #560762 - Flags: approval-comm-aurora?
Attachment #560762 - Flags: approval-comm-aurora? → approval-comm-aurora+
Depends on: 689152
Depends on: 689963
You need to log in before you can comment on or make changes to this bug.