683149 - Break out layout memory reporters on a per-shell basis

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Screenshot

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 556825 [details] [diff] [review]
Patch

>+  nsCAutoString str;
>+  str.AssignLiteral("explicit/layout/shell(");

  nsCAutoString str("explicit/layout/shell(");

Seems clearer.

r=me

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 556825 [details] [diff] [review]
Patch

Review of attachment 556825 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsPresShell.cpp
@@ +1469,5 @@
> +
> +      // A hack: replace forward slashes with '\\' so they aren't
> +      // treated as path separators.  Users of the reporters
> +      // (such as about:memory) have to undo this change.
> +      spec.ReplaceChar('/', '\\');

Oh god, this code is going to end up being cut+pasted in half a dozen places eventually :(

Comment 4

[Nicholas Nethercote [inactive]]

khuey, can you post sample output from about:memory?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Nicholas Nethercote [:njn] from comment #4)
> khuey, can you post sample output from about:memory?

See the screenshot?

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/mozilla-central/rev/94b987001b38

Comment 8

[Nicholas Nethercote [inactive]]

> See the screenshot?

Oh!  Nice.  One thing I've partly done with JS and am thinking about doing more consistently is to use the "Other measurements" list to aggregate these per-compartment/URI/whatever measurements.  In other words, it would be interesting to have "layout/styledata" and "layout/arenas" totals in "other measurements", to save you having to manually add up the individual counts.

Also, any reason you didn't use "style-data"? :)