Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Break out layout memory reporters on a per-shell basis

RESOLVED FIXED in mozilla9

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P2])

Attachments

(2 attachments)

Created attachment 556825 [details] [diff] [review]
Patch
Attachment #556825 - Flags: review?(bzbarsky)
Created attachment 556826 [details]
Screenshot
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink:P2]

Comment 2

6 years ago
Comment on attachment 556825 [details] [diff] [review]
Patch

>+  nsCAutoString str;
>+  str.AssignLiteral("explicit/layout/shell(");

  nsCAutoString str("explicit/layout/shell(");

Seems clearer.

r=me
Attachment #556825 - Flags: review?(bzbarsky) → review+
Comment on attachment 556825 [details] [diff] [review]
Patch

Review of attachment 556825 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsPresShell.cpp
@@ +1469,5 @@
> +
> +      // A hack: replace forward slashes with '\\' so they aren't
> +      // treated as path separators.  Users of the reporters
> +      // (such as about:memory) have to undo this change.
> +      spec.ReplaceChar('/', '\\');

Oh god, this code is going to end up being cut+pasted in half a dozen places eventually :(
khuey, can you post sample output from about:memory?
Duplicate of this bug: 674922
(In reply to Nicholas Nethercote [:njn] from comment #4)
> khuey, can you post sample output from about:memory?

See the screenshot?
http://hg.mozilla.org/mozilla-central/rev/94b987001b38
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: 8 Branch → Trunk
> See the screenshot?

Oh!  Nice.  One thing I've partly done with JS and am thinking about doing more consistently is to use the "Other measurements" list to aggregate these per-compartment/URI/whatever measurements.  In other words, it would be interesting to have "layout/styledata" and "layout/arenas" totals in "other measurements", to save you having to manually add up the individual counts.

Also, any reason you didn't use "style-data"? :)
Depends on: 684323
You need to log in before you can comment on or make changes to this bug.