Closed
Bug 683149
Opened 13 years ago
Closed 13 years ago
Break out layout memory reporters on a per-shell basis
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: khuey, Assigned: khuey)
References
Details
(Whiteboard: [MemShrink:P2])
Attachments
(2 files)
5.81 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
24.09 KB,
image/png
|
Details |
No description provided.
Attachment #556825 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Whiteboard: [MemShrink]
Updated•13 years ago
|
Whiteboard: [MemShrink] → [MemShrink:P2]
Comment 2•13 years ago
|
||
Comment on attachment 556825 [details] [diff] [review] Patch >+ nsCAutoString str; >+ str.AssignLiteral("explicit/layout/shell("); nsCAutoString str("explicit/layout/shell("); Seems clearer. r=me
Attachment #556825 -
Flags: review?(bzbarsky) → review+
Comment 3•13 years ago
|
||
Comment on attachment 556825 [details] [diff] [review] Patch Review of attachment 556825 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/base/nsPresShell.cpp @@ +1469,5 @@ > + > + // A hack: replace forward slashes with '\\' so they aren't > + // treated as path separators. Users of the reporters > + // (such as about:memory) have to undo this change. > + spec.ReplaceChar('/', '\\'); Oh god, this code is going to end up being cut+pasted in half a dozen places eventually :(
Comment 4•13 years ago
|
||
khuey, can you post sample output from about:memory?
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #4) > khuey, can you post sample output from about:memory? See the screenshot?
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/94b987001b38
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: 8 Branch → Trunk
Comment 8•13 years ago
|
||
> See the screenshot?
Oh! Nice. One thing I've partly done with JS and am thinking about doing more consistently is to use the "Other measurements" list to aggregate these per-compartment/URI/whatever measurements. In other words, it would be interesting to have "layout/styledata" and "layout/arenas" totals in "other measurements", to save you having to manually add up the individual counts.
Also, any reason you didn't use "style-data"? :)
You need to log in
before you can comment on or make changes to this bug.
Description
•