684323 - about:memory should use text-overflow: ellipsis in non-verbose mode

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Justin Lebar (not reading bugmail)]

In non-verbose about:memory, compartment URLs are shortened:

  compartment(https://bugzilla.mozilla.org/show_bug.cg...)

but layout/shell URLs are not.

Comment 1

[Justin Lebar (not reading bugmail)]

Oh, awesome, the ellipsis overflow is hacked using truncateCompartmentName in about:memory.

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 558992 [details] [diff] [review]
Patch v1

Review of attachment 558992 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this.  I tried to do it a while ago but I didn't know the exact CSS incantations.

::: toolkit/components/aboutmemory/tests/chrome/test_aboutmemory.xul
@@ +143,5 @@
>      f("2nd", "explicit/a/b/c",  HEAP,      1 * MB), // dup: merge
>      f("2nd", "explicit/a/b/c",  HEAP,      1 * MB), // dup: merge
>      f("2nd", "explicit/flip\\the\\backslashes",
>                                  HEAP,    200 * MB),
> +    f("2nd", "explicit/compartment(compartment-url)",

Hmm, it's a shame the truncation isn't tested any more.  I guess it's difficult because the truncation point depends on how wide the window is?

Comment 4

[Justin Lebar (not reading bugmail)]

> Hmm, it's a shame the truncation isn't tested any more.  I guess it's difficult because the 
> truncation point depends on how wide the window is?

Yes, and it also depends on the specific font we use.

Comment 5

[Justin Lebar (not reading bugmail)]

inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/aa0168e8e389

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/aa0168e8e389