683167 - Disable tablet UI during unit testing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

By default, we want the tablet UI to auto-detect and enable itself when appropriate. During unit testing, we want more control. We will disable the tablet UI by default during testing.

If test want to enable the UI, they can do so during the test itself.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 556849 [details] [diff] [review]
patch

Review of attachment 556849 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/automation.py.in
@@ +335,5 @@
>  user_pref("browser.console.showInPanel", true);
>  user_pref("browser.dom.window.dump.enabled", true);
>  user_pref("browser.firstrun.show.localepicker", false);
>  user_pref("browser.firstrun.show.uidiscovery", false);
> +user_pref("browser.ui.layout.tablet", 0); // force tablet UI off

this will affect all mochitests desktop and mobile.  Will the have any effect on desktop?  I assume they won't, but wanted to ask just in case.

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to Joel Maher (:jmaher) from comment #1)
> this will affect all mochitests desktop and mobile.  Will the have any
> effect on desktop?  I assume they won't, but wanted to ask just in case.

The browser.ui.layout.tablet pref will have no effect on desktop.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c29ca6c939c8

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/c29ca6c939c8