Closed Bug 683167 Opened 8 years ago Closed 8 years ago

Disable tablet UI during unit testing

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 9

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Whiteboard: qa?)

Attachments

(1 file)

Attached patch patchSplinter Review
By default, we want the tablet UI to auto-detect and enable itself when appropriate. During unit testing, we want more control. We will disable the tablet UI by default during testing.

If test want to enable the UI, they can do so during the test itself.
Attachment #556849 - Flags: review?(jmaher)
Assignee: nobody → mark.finkle
Blocks: 681980
OS: Linux → All
Hardware: x86 → All
Comment on attachment 556849 [details] [diff] [review]
patch

Review of attachment 556849 [details] [diff] [review]:
-----------------------------------------------------------------

::: build/automation.py.in
@@ +335,5 @@
>  user_pref("browser.console.showInPanel", true);
>  user_pref("browser.dom.window.dump.enabled", true);
>  user_pref("browser.firstrun.show.localepicker", false);
>  user_pref("browser.firstrun.show.uidiscovery", false);
> +user_pref("browser.ui.layout.tablet", 0); // force tablet UI off

this will affect all mochitests desktop and mobile.  Will the have any effect on desktop?  I assume they won't, but wanted to ask just in case.
Attachment #556849 - Flags: review?(jmaher) → review+
(In reply to Joel Maher (:jmaher) from comment #1)
> this will affect all mochitests desktop and mobile.  Will the have any
> effect on desktop?  I assume they won't, but wanted to ask just in case.

The browser.ui.layout.tablet pref will have no effect on desktop.
http://hg.mozilla.org/mozilla-central/rev/c29ca6c939c8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Whiteboard: qa?
You need to log in before you can comment on or make changes to this bug.