683296 - Clean up GL Layers prefs and whitelisting on Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ali Juma [:ajuma]]

We have two prefs controlling the enabling of GL Layers: layers.acceleration.disabled and layers.acceleration.force-enabled.

GL Layers are enabled on a device if two conditions are met:
1) layers.acceleration.disabled = false
2) layers.acceleration.force-enabled = true OR the device is whitelisted in GfxInfo::GetFeatureStatusImpl.

On Android, the current default values are:
1) layers.acceleration.disabled = true
2) layers.acceleration.force-enabled = false

The only whitelisted device is the Samsung Galaxy S (for historical reasons, not because we think GL Layers should be turned on there).

We should change the default value of layers.acceleration.disabled to false, and remove the whitelisting of the Galaxy S. (The combination of these changes will mean that GL Layers will still be off by default on all Android devices.)

Then, when we're ready to turn on GL Layers by default for a particular device, it will suffice to whitelist it in GfxInfo.

Comment 1

[Ali Juma [:ajuma]]

Attachment: Change default of layers.acceleration.disabled to false, and blacklist Galaxy S

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 557000 [details] [diff] [review]
Change default of layers.acceleration.disabled to false, and blacklist Galaxy S

It's probably better to just comment out the whitelisting block. I think it's worth keeping the code for detecting Galaxy S's around.

Comment 3

[Ali Juma [:ajuma]]

Attachment: Change default of layers.acceleration.disabled to false, and blacklist Galaxy S

Patch updated to address review comments. Carrying forward r=jrmuizel.

Comment 4

[Ali Juma [:ajuma]]

Attachment: Change default of layers.acceleration.disabled to false, and blacklist Galaxy S

Fixed a comment.

Comment 5

[Benoit Girard (:BenWa)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/915acb9f6d29

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/915acb9f6d29

Comment 7

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:9.0a2) Gecko/20111017 Firefox/9.0a2 Fennec/9.0a2
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111018 Firefox/10.0a1 Fennec/10.0a1
Device: HTC Desire Z -  Android 2.3, 
        Samsung Galaxy S - Android 2.2

Verified on both Nightly and Aurora, by default:
1) layers.acceleration.disabled = false
2) layers.acceleration.force-enabled = false