Remove build support for standalone necko and standalone xslt transformiix

RESOLVED FIXED in mozilla9

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: emorley)

Tracking

({dev-doc-complete})

Trunk
mozilla9
dev-doc-complete
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Ed if you don't feel like working on this bug then please re-assign it to me.
Flags: in-testsuite-
Created attachment 557326 [details] [diff] [review]
A: Build system changes

Removes support for building standalone xslt & standalone necko.

Have separated out file removals for easier review.
Attachment #557326 - Flags: review?(khuey)
Created attachment 557332 [details] [diff] [review]
B: File removals

Removes confvars.sh + build.mk from both content/xslt/ and netwerk/, since only used when building standalone. 

Post makefile changes in part 1, a bunch of files in content/xslt/src/ are now unused, so take those out too.
Attachment #557332 - Flags: review?(khuey)
Roping in the xslt owners to see if they have objections to dropping standalone transformiix.
Created attachment 557333 [details] [diff] [review]
C: Remove #ifdef TX_EXE

After part A, TX_EXE is never defined:
http://mxr.mozilla.org/mozilla-central/search?string=TX_EXE
Attachment #557333 - Flags: review?(khuey)
Status: NEW → ASSIGNED
I'm all for this, but Peterv is the module owner.
Let's do it.
Attachment #557326 - Flags: review?(khuey) → review+
Attachment #557332 - Flags: review?(khuey) → review+
Attachment #557333 - Flags: review?(khuey) → review+
B and C are mechanical, I trust your ability to delete files correctly, so I didn't actually look at these.
Thanks khuey :-)

http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c902a63fb74c

A: http://hg.mozilla.org/integration/mozilla-inbound/rev/df264cbf7b9c
B: http://hg.mozilla.org/integration/mozilla-inbound/rev/0c97e9647100
C: http://hg.mozilla.org/integration/mozilla-inbound/rev/962b157801a6
Target Milestone: --- → mozilla9
It'd be awesome to also kill txAtoms.h and do 
s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g
On my list for a followup :-)

(Wanted to try and keep the more mechanical changes separate so khuey didn't have to actually read a 220kb patch :-))
http://hg.mozilla.org/mozilla-central/rev/962b157801a6
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
That was C, and we also have:

B: http://hg.mozilla.org/mozilla-central/rev/0c97e9647100
A: http://hg.mozilla.org/mozilla-central/rev/df264cbf7b9c
Blocks: 687326

Updated

6 years ago
Duplicate of this bug: 475833
Seeing the similar --enable-application=standalone change listed on https://developer.mozilla.org/en/Firefox_9_for_developers makes me dev-doc-needed may be appropriate for this as well. (Sorry for adding it late).
Keywords: dev-doc-needed
Docs updated:

https://developer.mozilla.org/En/Building_Necko_standalone
https://developer.mozilla.org/en/Building_XXX_Standalone

Also mentioned on Firefox 9 for developers.

Thanks for calling this to our attention!
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.