683416 - Remove build support for standalone necko and standalone xslt transformiix

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Matheus Kerschbaum]

Ed if you don't feel like working on this bug then please re-assign it to me.

Comment 1

[Ed Morley [:emorley]]

Attachment: A: Build system changes

Removes support for building standalone xslt & standalone necko.

Have separated out file removals for easier review.

Comment 2

[Ed Morley [:emorley]]

Attachment: B: File removals

Removes confvars.sh + build.mk from both content/xslt/ and netwerk/, since only used when building standalone. 

Post makefile changes in part 1, a bunch of files in content/xslt/src/ are now unused, so take those out too.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Roping in the xslt owners to see if they have objections to dropping standalone transformiix.

Comment 4

[Ed Morley [:emorley]]

Attachment: C: Remove #ifdef TX_EXE

After part A, TX_EXE is never defined:
http://mxr.mozilla.org/mozilla-central/search?string=TX_EXE

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I'm all for this, but Peterv is the module owner.

Comment 6

[Peter Van der Beken [:peterv]]

Let's do it.

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

B and C are mechanical, I trust your ability to delete files correctly, so I didn't actually look at these.

Comment 8

[Ed Morley [:emorley]]

Thanks khuey :-)

http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=c902a63fb74c

A: http://hg.mozilla.org/integration/mozilla-inbound/rev/df264cbf7b9c
B: http://hg.mozilla.org/integration/mozilla-inbound/rev/0c97e9647100
C: http://hg.mozilla.org/integration/mozilla-inbound/rev/962b157801a6

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

It'd be awesome to also kill txAtoms.h and do 
s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g

Comment 10

[Ed Morley [:emorley]]

On my list for a followup :-)

(Wanted to try and keep the more mechanical changes separate so khuey didn't have to actually read a 220kb patch :-))

Comment 11

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/962b157801a6

Comment 12

[(no longer active)]

That was C, and we also have:

B: http://hg.mozilla.org/mozilla-central/rev/0c97e9647100
A: http://hg.mozilla.org/mozilla-central/rev/df264cbf7b9c

Comment 14

[Ed Morley [:emorley]]

Seeing the similar --enable-application=standalone change listed on https://developer.mozilla.org/en/Firefox_9_for_developers makes me dev-doc-needed may be appropriate for this as well. (Sorry for adding it late).

Comment 15

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/En/Building_Necko_standalone
https://developer.mozilla.org/en/Building_XXX_Standalone

Also mentioned on Firefox 9 for developers.

Thanks for calling this to our attention!