Closed Bug 687326 Opened 12 years ago Closed 12 years ago

Kill txAtoms.h and s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g

Categories

(Core :: XSLT, defect)

Product:
Core
Component:
XSLT
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Patch v1
108.84 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
In bug 683416, support for standalone xslt was removed, meaning that some of the typedefs that used to be in #ifndef TX_EXE blocks are now redundant.

Sicking in bug 683416 comment 9:
> It'd be awesome to also kill txAtoms.h and do 
> s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g
Flags: in-testsuite-
Attached patch Patch v1 — — Splinter Review 
- Hg removes txAtoms.h
- s/#include "txAtoms.h"/#include "nsGkAtoms.h"/g
- s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g

Builds fine locally, sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=6d1bcb9a507a
Attachment #560777 - Flags: review?(jonas)
https://hg.mozilla.org/mozilla-central/rev/1d5cdab249a9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.