Last Comment Bug 687326 - Kill txAtoms.h and s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g
: Kill txAtoms.h and s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XSLT (show other bugs)
: Trunk
: All All
: -- minor (vote)
: mozilla9
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on: 683416
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-18 04:19 PDT by Ed Morley [:emorley]
Modified: 2011-09-20 07:46 PDT (History)
5 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (108.84 KB, patch)
2011-09-18 05:06 PDT, Ed Morley [:emorley]
jonas: review+
Details | Diff | Review

Description Ed Morley [:emorley] 2011-09-18 04:19:28 PDT
In bug 683416, support for standalone xslt was removed, meaning that some of the typedefs that used to be in #ifndef TX_EXE blocks are now redundant.

Sicking in bug 683416 comment 9:
> It'd be awesome to also kill txAtoms.h and do 
> s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g
Comment 1 Ed Morley [:emorley] 2011-09-18 05:06:28 PDT
Created attachment 560777 [details] [diff] [review]
Patch v1

- Hg removes txAtoms.h
- s/#include "txAtoms.h"/#include "nsGkAtoms.h"/g
- s/txXPathAtoms|txXMLAtoms|txXSLTAtoms|txHTMLAtoms/nsGkAtoms/g

Builds fine locally, sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=6d1bcb9a507a
Comment 3 :Ehsan Akhgari (out sick) 2011-09-20 07:46:11 PDT
https://hg.mozilla.org/mozilla-central/rev/1d5cdab249a9

Note You need to log in before you can comment on or make changes to this bug.