Closed
Bug 683482
Opened 13 years ago
Closed 13 years ago
remove replaceWholeText()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: annevk, Assigned: matjk7)
References
Details
(Keywords: addon-compat, dev-doc-complete)
Attachments
(1 file, 4 obsolete files)
20.09 KB,
patch
|
matjk7
:
review+
|
Details | Diff | Splinter Review |
Per http://www.w3.org/Bugs/Public/show_bug.cgi?id=13046 it would be great if this method got removed so it can be removed from DOM Core. (Acid3 relies on this, but Acid3 needs to change anyway.)
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #560768 -
Flags: review?(jonas)
Comment on attachment 560768 [details] [diff] [review] patch Review of attachment 560768 [details] [diff] [review]: ----------------------------------------------------------------- yay
Attachment #560768 -
Flags: review?(jonas) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 3•13 years ago
|
||
How confident are we that this is not going to break any website? Should we wait for the next merge (in 8 days) to increase the test period?
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3) > How confident are we that this is not going to break any website? Should we > wait for the next merge (in 8 days) to increase the test period? You're right this doesn't need to land right now.
Keywords: checkin-needed
Whiteboard: [land for Firefox 10]
Assignee | ||
Updated•13 years ago
|
Keywords: dev-doc-needed
If you're doing that, please add a warning to current builds as to increase the chances that anyone using this fixes their site.
Comment 6•13 years ago
|
||
This patch would be useful if you want to use nsIDocument::WarnOnceAbout. (We've got 32 warnings already.)
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [land for Firefox 10]
Updated•13 years ago
|
Attachment #561137 -
Attachment is obsolete: true
Comment 7•13 years ago
|
||
This patch isn't going to apply, due to the warning added in bug 688190, which you also need to remove.
Keywords: checkin-needed
Assignee | ||
Comment 8•13 years ago
|
||
Updated to tip.
Attachment #560768 -
Attachment is obsolete: true
Attachment #563176 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 10•13 years ago
|
||
Comment on attachment 563176 [details] [diff] [review] patch for checkin ... and nsDeprecatedOperationList.h
Attachment #563176 -
Flags: review+
Assignee | ||
Comment 11•13 years ago
|
||
Attachment #563176 -
Attachment is obsolete: true
Attachment #563183 -
Flags: review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 12•13 years ago
|
||
patching file content/base/src/nsGenericDOMDataNode.h Hunk #1 FAILED at 324
Assignee | ||
Comment 13•13 years ago
|
||
Attachment #563183 -
Attachment is obsolete: true
Attachment #563575 -
Flags: review+
Comment 14•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5f0f1b44e73d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•13 years ago
|
Keywords: addon-compat
Comment 15•13 years ago
|
||
I've updated: https://developer.mozilla.org/En/DOM/Text#section_2 https://developer.mozilla.org/En/DOM/Text.replaceWholeText and https://developer.mozilla.org/en/Firefox_10_for_developers#DOM4
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•