remove replaceWholeText()

RESOLVED FIXED in mozilla10

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: annevk, Assigned: Matheus Kerschbaum)

Tracking

({addon-compat, dev-doc-complete})

Trunk
mozilla10
addon-compat, dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

6 years ago
Per http://www.w3.org/Bugs/Public/show_bug.cgi?id=13046 it would be great if this method got removed so it can be removed from DOM Core.

(Acid3 relies on this, but Acid3 needs to change anyway.)
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
(Assignee)

Updated

6 years ago
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 560768 [details] [diff] [review]
patch
Attachment #560768 - Flags: review?(jonas)
Comment on attachment 560768 [details] [diff] [review]
patch

Review of attachment 560768 [details] [diff] [review]:
-----------------------------------------------------------------

yay
Attachment #560768 - Flags: review?(jonas) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
How confident are we that this is not going to break any website? Should we wait for the next merge (in 8 days) to increase the test period?
(Assignee)

Comment 4

6 years ago
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #3)
> How confident are we that this is not going to break any website? Should we
> wait for the next merge (in 8 days) to increase the test period?

You're right this doesn't need to land right now.
Keywords: checkin-needed
Whiteboard: [land for Firefox 10]
(Assignee)

Updated

6 years ago
Keywords: dev-doc-needed
If you're doing that, please add a warning to current builds as to increase the chances that anyone using this fixes their site.
Created attachment 561137 [details] [diff] [review]
Patch to allow using nsIDocument::WarnOnceAbout for more cases

This patch would be useful if you want to use nsIDocument::WarnOnceAbout. (We've got 32 warnings already.)

Updated

6 years ago
Depends on: 688190
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [land for Firefox 10]

Updated

6 years ago
Attachment #561137 - Attachment is obsolete: true
This patch isn't going to apply, due to the warning added in bug 688190, which you also need to remove.
Keywords: checkin-needed
(Assignee)

Comment 8

6 years ago
Created attachment 563176 [details] [diff] [review]
patch for checkin

Updated to tip.
Attachment #560768 - Attachment is obsolete: true
Attachment #563176 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
You forgot to update dom.properties.
Keywords: checkin-needed
Comment on attachment 563176 [details] [diff] [review]
patch for checkin

... and nsDeprecatedOperationList.h
Attachment #563176 - Flags: review+
(Assignee)

Comment 11

6 years ago
Created attachment 563183 [details] [diff] [review]
patch for checkin
Attachment #563176 - Attachment is obsolete: true
Attachment #563183 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
patching file content/base/src/nsGenericDOMDataNode.h
Hunk #1 FAILED at 324
(Assignee)

Comment 13

6 years ago
Created attachment 563575 [details] [diff] [review]
patch for checkin
Attachment #563183 - Attachment is obsolete: true
Attachment #563575 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/5f0f1b44e73d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Keywords: addon-compat
I've updated:
https://developer.mozilla.org/En/DOM/Text#section_2
https://developer.mozilla.org/En/DOM/Text.replaceWholeText
and
https://developer.mozilla.org/en/Firefox_10_for_developers#DOM4
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.