The default bug view has changed. See this FAQ.

Port bug 682803 |can't set address book in filters|

RESOLVED FIXED in seamonkey2.6

Status

SeaMonkey
MailNews: Address Book & Contacts
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.6

SeaMonkey Tracking Flags

(seamonkey2.4 fixed, seamonkey2.5 fixed, seamonkey2.6 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 557314 [details] [diff] [review]
patch [Checkin: comments 3 and 4]

Bug 682803 just landed on comm-central, -aurora and -beta. We need to follow suit since we're affected, too and the code is not shared (but very similar). I only checked trunk so far.

Note that I hardly know what I'm doing here, just ported what the TB guys did.
Attachment #557314 - Flags: superreview?(neil)
Attachment #557314 - Flags: review?(mnyromyr)

Comment 1

6 years ago
Comment on attachment 557314 [details] [diff] [review]
patch [Checkin: comments 3 and 4]

I would want to retain the search-value-popup class; themes might be using it. sr=me with class="search-value-popup addrbooksPopup".

Do you know if there's a bug on removing abDirTreeOverlay.xul? It's the last "reference" to rdf:addressdirectory, but I think it's obsolete.
Attachment #557314 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 2

6 years ago
(In reply to neil@parkwaycc.co.uk from comment #1)
> Do you know if there's a bug on removing abDirTreeOverlay.xul? It's the last
> "reference" to rdf:addressdirectory, but I think it's obsolete.

A simple Bugzilla search finds bug 677859, which was filed about three weeks ago by... you. Oblivious? ;-)

Updated

6 years ago
Attachment #557314 - Flags: review?(mnyromyr) → review+
(Assignee)

Updated

6 years ago
Attachment #557314 - Flags: approval-comm-beta?
Attachment #557314 - Flags: approval-comm-aurora?
(Assignee)

Comment 3

6 years ago
Comment on attachment 557314 [details] [diff] [review]
patch [Checkin: comments 3 and 4]

http://hg.mozilla.org/comm-central/rev/87d74a675cbc
Attachment #557314 - Attachment description: patch → patch [Checkin: comment 3]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-seamonkey2.6: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6

Updated

6 years ago
Attachment #557314 - Flags: approval-comm-beta?
Attachment #557314 - Flags: approval-comm-beta+
Attachment #557314 - Flags: approval-comm-aurora?
Attachment #557314 - Flags: approval-comm-aurora+
(Assignee)

Comment 4

6 years ago
Comment on attachment 557314 [details] [diff] [review]
patch [Checkin: comments 3 and 4]

http://hg.mozilla.org/releases/comm-aurora/rev/2d56b3334e86
http://hg.mozilla.org/releases/comm-beta/rev/e40f9a5e8de1
Attachment #557314 - Attachment description: patch [Checkin: comment 3] → patch [Checkin: comments 3 and 4]
(Assignee)

Updated

6 years ago
status-seamonkey2.4: --- → fixed
status-seamonkey2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.